!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

230 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture51 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
31 Aug 2023
@infinisil:matrix.orginfinisil * But yeah, all of those callPackages could be gotten rid of, but that also does affect the override interface, and it makes the definitions a bit more complicated, so I don't want to touch that in that PR18:33:28
@k900:0upti.meK900Yes, and all it took was like five screens of drama18:34:40
@raitobezarius:matrix.orgraitobezariusWell, amjoseph is probably the one behind it I guess18:35:11
@infinisil:matrix.orginfinisil
In reply to @infinisil:matrix.org
Question for https://github.com/NixOS/nixpkgs/pull/237439:
We can almost declare all top-level packages in pkgs/by-name, except ones that should be declared using e.g. python3Packages.callPackage, libsForQt5.callPackage, etc.
So then, regarding this, I think it should be fine to say that new top-level packages should always be added to pkgs/by-name
18:40:59
@infinisil:matrix.orginfinisil Because there shouldn't be a need to use e.g. python3Packages.callPackage for new packages 18:41:14
@infinisil:matrix.orginfinisilAlthough.. that does change conventions18:41:23
@infinisil:matrix.orginfinisil Nah let's not do that, I'll just mention that you still have to use the category hierarchy and all-packages.nix for those cases. 18:41:51
@infinisil:matrix.orginfinisil It's likely that conventions automatically change to not use alternate callPackage's anymore from that 18:42:14
@k900:0upti.meK900For python3Packages maybe we'd want a secondary hierarchy18:42:09
@k900:0upti.meK900Like pkgs/python/by-name/*18:42:15
@k900:0upti.meK900Just because there's a lot of them18:42:23
@infinisil:matrix.orginfinisilNon-top-level packages are another store18:42:43
@infinisil:matrix.orginfinisil * Non-top-level packages are another story18:42:44
@infinisil:matrix.orginfinisil RFC 140 and pkgs/by-name is indeed only concerned with top-level packages 18:42:55
@infinisil:matrix.orginfinisil@room As with last week, I have now cleaned up https://github.com/NixOS/nixpkgs/pull/237439, part 1b of RFC 140. Please review this until Tuesday, where we have a meeting scheduled to do a final review and merge (if everything looks good)! The meeting is on 2023-09-05 15:30 CEST in https://meet.jit.si/nixpkgs-architecture and anybody is invited, but the most members of the Nixpkgs Architecture Team are expected to be there.21:12:33

Show newer messages


Back to Room ListRoom Version: 9