!djTaTBQyWEPRQxrPTb:nixos.org

Nixpkgs Architecture Team

228 Members
https://github.com/nixpkgs-architecture, weekly public meetings on Wednesday 15:00-16:00 UTC at https://meet.jit.si/nixpkgs-architecture53 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
27 Sep 2023
@infinisil:matrix.orginfinisil
In reply to @piegames:matrix.org
Also, this is not the problem desribed in your issue, as far as I read it
True, it's applicable in the same way though
17:45:57
@infinisil:matrix.orginfinisilHmm let me see if it's possible to somehow re-trigger checks17:47:07
@infinisil:matrix.orginfinisilThough, poor ofborg could just die from that..17:47:17
@infinisil:matrix.orginfinisilOkay maybe we could be very specific with it. Only re-trigger CI for PR's that touch all-packages.nix17:47:59
@piegames:matrix.org@piegames:matrix.orgHow about making stricter checks soft-fail for a while at first instead?17:48:52
@infinisil:matrix.orginfinisilThat's kind of what https://github.com/NixOS/nixpkgs/issues/256788 is about17:49:30
@piegames:matrix.org@piegames:matrix.orgI must admit that I am completely lost in the issue text, after reading it twice17:51:02
@infinisil:matrix.orginfinisilYeah sorry I admit it's really hard to read..17:51:15
@infinisil:matrix.orginfinisilJust a wall of text 😅17:51:24
@infinisil:matrix.orginfinisilFor the nixcon presentation it was fun trying to come up with visual explanations of things, I'll try the same here :)18:08:28
@infinisil:matrix.orginfinisil piegames: https://github.com/NixOS/nixpkgs/issues/256788#issuecomment-1737965650 19:33:48
@piegames:matrix.org@piegames:matrix.orghttps://github.com/NixOS/nixpkgs/issues/256788#issuecomment-1737979351 yeah I think this was the actual cause for my confusion19:48:32
@infinisil:matrix.orginfinisil Yeah, well I'm glad I was able to explain it, it's useful specific to nixpkgs-check-by-name, but a CI retrigger is a decent fix the other general problem :) 19:49:34
@infinisil:matrix.orginfinisil * Yeah, well I'm glad I was able to explain it, it's useful specific to nixpkgs-check-by-name, but a CI retrigger is a decent fix for the other general problem :) 19:49:44
@infinisil:matrix.orginfinisilOh and I guess this could also be useful if it's too expensive to re-trigger the CI check for all affected PR's19:52:08
@infinisil:matrix.orginfinisil (not the case for nixpkgs-check-by-name) 19:52:22
@infinisil:matrix.orginfinisilKind of nice how this approach allows a gradual rollout of a new CI check though. And you can kind of control the amount of the rollout based on how quickly you fix the base branch when the new check starts failing on it.19:58:30
@infinisil:matrix.orginfinisil * Kind of nice how this approach allows a gradual rollout of a new CI check without using any extra resources though. And you can kind of control the amount of the rollout based on how quickly you fix the base branch when the new check starts failing on it.19:58:46
@infinisil:matrix.orginfinisilNice, the RFC 140 tool prevented the double addition of a package: https://github.com/NixOS/nixpkgs/pull/25756521:12:28

Show newer messages


Back to Room ListRoom Version: 9