| 9 May 2022 |
 Pol | In reply to @jtojnar:matrix.org
finding yacc itself will be easy but what should you set YFLAGS to? And what if upstream changes it? Maybe adding it on the top of the file might be a better fit | 19:36:53 |
| Pol | Damn, let me know what we do :) | 19:39:02 |
 Jan Tojnar | Pol: if you could try pasting those lines to the top of ext/pdo/config.m4 in postPatch that would be a start | 19:45:44 |
| Pol | Right, going to experiment ;) | 19:46:00 |
| Pol | Thanks ! | 19:46:04 |
| Pol | Something like that I guess ? or you have a better option ? | 19:49:34 |
| Pol | 
Download image.png | 19:49:36 |
| Pol | trying to build... | 19:51:58 |
| Pol | Big nope. | 19:54:44 |
| Jan Tojnar | postPatch expects commands | 19:57:14 |
| Jan Tojnar | try something like https://github.com/NixOS/nixpkgs/pull/170962/files#diff-53e28b8539b04d6898db30da46a18a0bd1747d920ec8e70df2cd78eb1c0fb69bR555-R560 | 19:57:35 |
| Jan Tojnar | * Pol: try something like https://github.com/NixOS/nixpkgs/pull/170962/files#diff-53e28b8539b04d6898db30da46a18a0bd1747d920ec8e70df2cd78eb1c0fb69bR555-R560 | 19:57:55 |
| Pol | It's building... wait & see. | 20:00:16 |
| Pol | working ! | 20:01:49 |
| Pol | Submitting the patch. | 20:01:53 |
| Pol | Next issue: sodium extension. | 20:18:53 |
| Pol | https://github.com/fossar/nix-phps/runs/6358975765?check_suite_focus=true | 20:18:57 |
| Jan Tojnar | where does the lex call even come from? https://github.com/fossar/nix-phps/runs/6358975765?check_suite_focus=true#step:6:835 | 20:23:03 |
| Jan Tojnar | there is no such rule in the Makefile fragments, maybe an implicit rule?
https://github.com/php/php-src/blob/f590782b60a4da31487e00a3d0accfaf5d406b1d/ext/tokenizer/Makefile.frag#L1
https://github.com/php/php-src/blob/f590782b60a4da31487e00a3d0accfaf5d406b1d/Zend/Makefile.frag#L8 | 20:23:43 |
| Jan Tojnar | try grepping the code for lex | 20:24:05 |
| Jan Tojnar | * Pol: try grepping the code for lex | 20:24:08 |
| Pol | Looks like there is something missing, there are 2 spaces in the log. | 20:25:20 |
| Pol | 
Download image.png | 20:25:24 |
| Jan Tojnar | right, possibly lex flags | 20:26:03 |
| Pol | In reply to @jtojnar:matrix.org
Pol: try grepping the code for lex I add the --keep-failed flag and I grep ? | 20:26:56 |
| Jan Tojnar | yup | 20:27:04 |
| Jan Tojnar | you should see it in the generated Makefile | 20:27:20 |
| Jan Tojnar | and then try to find out where that part of Makefile comes from | 20:27:46 |
| Pol | okay | 20:28:26 |
| Pol | Weird, I succeeded to build it locally: | 20:29:17 |
