| 29 Dec 2022 |
Pol | *
cd nixpkgs
git checkout master
git pull
nix edit .#php.extensions.xdebug
- Replace the content of that derivation with the previous version:
{ buildPecl, lib, fetchFromGitHub, nix-update-script }:
let
version = "3.1.0";
in buildPecl {
inherit version;
pname = "xdebug";
src = fetchFromGitHub {
owner = "xdebug";
repo = "xdebug";
rev = version;
sha256 = "sha256-eT/N+mPhI1DyUKi+S770bWK09+CzmI1ZqnrxTXr5A2U=";
};
doCheck = true;
checkTarget = "test";
zendExtension = true;
passthru = {
updateScript = nix-update-script {};
};
meta = with lib; {
changelog = "https://github.com/xdebug/xdebug/releases/tag/${version}";
description = "Provides functions for function traces and profiling";
license = licenses.php301;
homepage = "https://xdebug.org/";
maintainers = teams.php.members;
};
}
| 11:08:54 |
Pol | *
cd nixpkgs
git checkout master
git pull
nix edit .#php.extensions.xdebug
- Replace the content of that derivation with the previous version:
{ buildPecl, lib, fetchFromGitHub, nix-update-script }:
let
version = "3.1.0";
in buildPecl {
inherit version;
pname = "xdebug";
src = fetchFromGitHub {
owner = "xdebug";
repo = "xdebug";
rev = version;
sha256 = "sha256-eT/N+mPhI1DyUKi+S770bWK09+CzmI1ZqnrxTXr5A2U=";
};
doCheck = true;
checkTarget = "test";
zendExtension = true;
passthru = {
updateScript = nix-update-script {};
};
meta = with lib; {
changelog = "https://github.com/xdebug/xdebug/releases/tag/${version}";
description = "Provides functions for function traces and profiling";
license = licenses.php301;
homepage = "https://xdebug.org/";
maintainers = teams.php.members;
};
}
- Run
nix-update --commit php.extensions.xdebug
| 11:09:33 |
Pol | As you can see, it doesn't get updated. | 11:09:54 |
Pol | There is something going on since the last update of nix-update. I'm pretty sure this was working when I started to do the PR ! | 11:10:16 |
Pol | * As you can see, it doesn't get updated. The derivation should be updated to 3.2.0, but it doesn't. | 11:11:28 |
Pol |  Download image.png | 11:12:10 |
Pol | We can see in the log: Update 3.1.0 -> 3.2.0 | 11:12:26 |
Pol | Maybe Jan Tojnar has an idea since he made a review point asking me to remove the attrName from the commits at https://github.com/NixOS/nixpkgs/pull/207605#pullrequestreview-1230907654 | 11:17:59 |
Pol | * Maybe Jan Tojnar has an idea since he made a review point asking me to remove the attrPath from the commits at https://github.com/NixOS/nixpkgs/pull/207605#pullrequestreview-1230907654 | 11:18:14 |
Pol | * 🛑 I think there is an issue with nix-update. | 11:20:24 |
Pol | *
cd nixpkgs
git checkout master
git pull
open pkgs/development/php-packages/xdebug/default.nix
- Replace the content of that derivation with the previous version:
{ buildPecl, lib, fetchFromGitHub, nix-update-script }:
let
version = "3.1.0";
in buildPecl {
inherit version;
pname = "xdebug";
src = fetchFromGitHub {
owner = "xdebug";
repo = "xdebug";
rev = version;
sha256 = "sha256-eT/N+mPhI1DyUKi+S770bWK09+CzmI1ZqnrxTXr5A2U=";
};
doCheck = true;
checkTarget = "test";
zendExtension = true;
passthru = {
updateScript = nix-update-script {};
};
meta = with lib; {
changelog = "https://github.com/xdebug/xdebug/releases/tag/${version}";
description = "Provides functions for function traces and profiling";
license = licenses.php301;
homepage = "https://xdebug.org/";
maintainers = teams.php.members;
};
}
- Run
nix-update --commit php.extensions.xdebug
| 11:23:22 |
Pol | I'm discussing with @mic92 in the meantime. I think this PR should not be merged anymore. | 11:30:13 |
Pol |  Download image.png | 11:30:49 |
Pol | Issue fixed: https://github.com/Mic92/nix-update/pull/123 | 13:08:34 |
Pol | tgerbet: Issue is fixed in nix-update, @mic92 will commit the change as soon as the PHP PR is merged ! | 13:13:16 |
Pol | tgerbet: I updated the PR accordingly, I simplified things as well, I guess it's much better. Let me know what you think. | 16:42:47 |
Pol | tgerbet: I found a better solution again... | 17:24:24 |
Pol | Sorry for the back and forth. | 17:25:47 |
Pol | I stop touching it now :) | 17:25:51 |
Pol | It's ready for me :) | 17:25:57 |
tgerbet | In reply to @drupol:matrix.org Sorry for the back and forth. It's fine, I just wish GitHub had a the possibility to see changes between two reviews like Gerrit 😅 | 17:28:25 |
tgerbet | In reply to @drupol:matrix.org Sorry for the back and forth. * It's fine, I just wish GitHub had the possibility to see changes between two reviews like Gerrit 😅 | 17:28:40 |
Pol | Me too | 17:28:58 |
Pol | Basicaly, I made the most changes in it: build-pecl.nix and php-packages.nix | 17:29:58 |
Pol | Merci ! | 18:37:32 |
| 31 Dec 2022 |
Pol | Jan Tojnar: I have been working on https://github.com/NixOS/nixpkgs/pull/180827 but I'm unable to trigger the update script.
I tried with nix-update -u php81 but I end up with error (see in the PR). I guess this is not the proper way to trigger it?
On the other hand, I updated the script (without being able to test it) as such, what do you think?
updateScript = writeShellScript "update.sh" ''
PATH=${lib.makeBinPath [ nix-update curl jq ]}
new_version=$(curl --silent "https://www.php.net/releases/active" | jq --raw-output '."${lib.versions.major version}"."${lib.versions.majorMinor version}".version')
nix-update --override-filename ./${lib.versions.majorMinor version}.nix --version "$new_version" php${lib.versions.major version}${lib.versions.minor version}
'';
| 14:21:18 |
Pol | * Jan Tojnar: I have been working on https://github.com/NixOS/nixpkgs/pull/180827 but I'm unable to trigger the update script.
I tried with nix-update -u php81 but I end up with error (see in the PR). I guess this is not the proper way to trigger it?
On the other hand, I updated the script (without being able to test it) as such, what do you think?
updateScript = writeShellScript "update.sh" ''
PATH=${lib.makeBinPath [ nix-update curl jq ]}
new_version=$(curl --silent "https://www.php.net/releases/active" | jq --raw-output '."${lib.versions.major version}"."${lib.versions.majorMinor version}".version')
nix-update --override-filename ./${lib.versions.majorMinor version}.nix --version "$new_version" php${lib.versions.major version}${lib.versions.minor version}
'';
| 14:21:44 |
| 1 Jan 2023 |
Pol | Happy new year all 🎊 ! | 01:04:30 |
| 3 Jan 2023 |
Pol | There's this PR which is awaiting for love: https://github.com/NixOS/nixpkgs/pull/207088 | 20:27:50 |
| 4 Jan 2023 |
Pol | This PR needs some love: https://github.com/NixOS/nixpkgs/pull/180827 | 10:23:47 |