| 1 Mar 2024 |
tgerbet | In reply to @wjjunyor:matrix.org https://github.com/wjjunyor/pegasus Try with something looking like this
diff --git a/wordpress-configuration.nix b/wordpress-configuration.nix
index 04805bc..54eceb1 100644
--- a/wordpress-configuration.nix
+++ b/wordpress-configuration.nix
@@ -10,13 +10,13 @@
environment.systemPackages = with pkgs; [ wp4nix php ];
environment.variables.WP_VERSION = "6.4";
- nixpkgs.overlays = [ (self: super:
- wordpressPackages {
- src = builtins.fetchGit {
+ nixpkgs.overlays = [
+ (self: super: {
+ wordpressPackages = builtins.fetchGit {
url = "https://git.helsinki.tools/helsinki-systems/wp4nix";
ref = "master";
};
- }
- )];
+ })
+ ];
}
| 09:38:03 |
tgerbet | In reply to @tgerbet:matrix.org
Dropping the require-dev in the composer.json and setting packages-dev to [] in the composer.lock seems to work
Running nixpkgs-review on it and submitting it to review
https://github.com/NixOS/nixpkgs/pull/292508 | 09:44:31 |
@patka_123:matrix.org | In the PR description it says fixes the build, but on the bottom it says failed to build codesniffer in the nixpkgs-review output | 09:50:32 |
tgerbet | php-cs-fixer !== php-codesniffer :) | 09:51:31 |
@patka_123:matrix.org | Jesus, ****** christ. I am soooo blind... | 09:52:07 |
@etu:failar.nu | In reply to @tgerbet:matrix.org https://github.com/NixOS/nixpkgs/pull/292508 Oh, nice :) I've noticed this problem because I'm still using 8.1 :p | 10:07:15 |
tgerbet | And fixing php81Packages.php-cs-fixer requires this patch and a patch like https://github.com/NixOS/nixpkgs/pull/292511
I will deal with it when it becomes possible
| 10:09:35 |
Pol | @tgerbet can't test your PR but I can merge it if builds are passing | 11:08:14 |
w | In reply to @tgerbet:matrix.org
Try with something looking like this
diff --git a/wordpress-configuration.nix b/wordpress-configuration.nix
index 04805bc..54eceb1 100644
--- a/wordpress-configuration.nix
+++ b/wordpress-configuration.nix
@@ -10,13 +10,13 @@
environment.systemPackages = with pkgs; [ wp4nix php ];
environment.variables.WP_VERSION = "6.4";
- nixpkgs.overlays = [ (self: super:
- wordpressPackages {
- src = builtins.fetchGit {
+ nixpkgs.overlays = [
+ (self: super: {
+ wordpressPackages = builtins.fetchGit {
url = "https://git.helsinki.tools/helsinki-systems/wp4nix";
ref = "master";
};
- }
- )];
+ })
+ ];
}
Worked, now goin for the new error msgs | 14:28:47 |
w | Tks | 14:28:54 |
w | Pol: once you asked me to try the new phpcomposer - but I lost track of the mesage. Could you send it to me again? | 14:31:06 |
w | * Pol: once you asked me to try the new php composer - but I lost track of the mesage. Could you send it to me again? | 14:46:51 |
Pol | Can't do that now on the phone. I'll be back tomorrow on my laptop . Ping me tomorrow and I'll see what I can do | 15:23:04 |
| 5 Mar 2024 |
Pol | I just had a meeting with Seldaek (Jordi B, the Composer's father). | 11:47:19 |
Pol | He gave me a better idea for the Composer builder. | 11:47:31 |
Pol | That idea is great because:
- It simplifies the composer builder
- It works with ALL the versions of composer including >= 2.7
| 11:48:11 |