| 22 Jun 2023 |
 Pol | That issue is preventing me from merging PHP 8.3 right now | 18:44:36 |
 tgerbet | Maybe move the blackfire attribute into something optional? Something like
// lib.optionalAttrs (!(lib.versionAtLeast php.version "8.3")) {
blackfire = ...
}
| 19:07:42 |
| Pol | Where ? I haven't seen that | 19:16:18 |
| 23 Jun 2023 |
| Pol | PHP 8.3 PR is ready for your review/merge at: https://github.com/NixOS/nixpkgs/pull/239151 | 06:57:55 |
| Pol | I'm not satisfied with how the blackfire extension is managed, but I guess this is something I will likely refine very soon | 06:58:51 |
| Pol | Anything left to do in here before I leave ? ^^ | 16:32:11 |
| tgerbet | Too tired after a day of meetings but I will take a look tomorrow 🙂 | 16:38:56 |
| tgerbet | You might want to fetchpatch the patch fixing the build of fileinfo, it just got merged upstream | 16:39:44 |
| Pol | Oh good idea. Doing it right now. | 16:44:04 |
| Pol | Job done. | 16:47:59 |
| Pol | tgerbet: Tests are failing with PHP 8.3: https://logs.ofborg.org/?key=nixos/nixpkgs.239151&attempt_id=b3b3603d-9438-44a1-9fd5-482484952538 | 21:44:49 |
| Pol | I can reproduce the issue locally, but I wasn't able to fix it. | 21:45:08 |
| 24 Jun 2023 |
|  @etu:failar.nu changed their profile picture. | 13:19:44 |
| 25 Jun 2023 |
| tgerbet | Looking at the stack traces the issue is caused when PHP do the clean up at the end of a request (it's the php_request_shutdown you see the stack trace) and more specifically when it deals with the sessions (php_rshutdown_session_globals).
nixosTests.php83.httpd and nixosTests.php83.pcre succeeds if you remove session from the list of enabled extensions | 11:09:18 |
| tgerbet | I do not think this is on us, I'm trying to bisect | 11:41:15 |
| tgerbet | Created https://github.com/php/php-src/issues/11529 | 13:18:59 |
| Pol | thanks for creating it and debugging it | 17:53:43 |
| 26 Jun 2023 |
| Pol | tgerbet: Ping | 11:53:11 |
| Pol | I updated the PR with the patch, but the tests are still failing locally and on Github. | 11:53:28 |
| Pol | I don't know if I applied the patch correctly though. | 11:53:37 |
| Pol | => https://github.com/NixOS/nixpkgs/pull/239151 | 11:53:44 |
| Pol | tgerbet: Do you think the patch is applied at the right place? | 12:23:12 |
| Pol | I believe I should move it to the session extension. Trying. | 14:48:33 |
| Pol | Tests are passing now :) | 15:04:52 |
| Pol | PHP 8.3 is now ready, tests are passing ! https://github.com/NixOS/nixpkgs/pull/239151 | 15:11:22 |
| Pol | For some reason, they are still broken. dammit. | 15:42:36 |
| Pol | They passed at some point, now they don't anymore. | 15:42:49 |
| Pol | It's working again... boooh | 17:05:02 |
| Pol | I'll merge this PR once everything is ok: https://github.com/NixOS/nixpkgs/pull/239151 | 17:05:23 |
| Pol | php 8.3.0 is now in Nix ! | 19:04:41 |
