!jngDrdMgndWibPCYsR:nixos.org

Nix PHP

76 Members
A room for PHP developers running on Nix22 Servers

Load older messages


SenderMessageTime
20 May 2023
@jtojnar:matrix.orgJan Tojnar well, I guess we could return includeDev flag but only use it to decide what to fetch but still include everything in the repository’s packages.json 14:09:25
@jtojnar:matrix.orgJan Tojnarthen the paths for dev packages would not exist but it would not matter14:10:11
@jtojnar:matrix.orgJan Tojnar * then the paths for dev packages would not exist but it would not matter as long as user always uses --no-dev 14:10:22
@drupol:matrix.orgPolI don't know if this would work.14:12:42
@drupol:matrix.orgPolImagine phpstan/phpstan is a hard dependency of a dependency.14:13:00
@drupol:matrix.orgPolWe would not download it then?14:13:12
@drupol:matrix.orgPol(btw, I added you as maintainer of https://github.com/drupol/composer-local-repo-plugin/ and cherry picked one of your commit from composition/c4)14:14:03
@drupol:matrix.orgPolI think that composer plugin should be hosted in nixpkgs, and not under my name.14:14:26
@drupol:matrix.orgPolBut ok, we can deal with that later.14:14:45
@drupol:matrix.orgPolI think I made something okayish.14:55:29
@drupol:matrix.orgPolI will push in a couple of seconds. Waiting for phpunit to be build.14:55:47
@jtojnar:matrix.orgJan Tojnar
In reply to @drupol:matrix.org
Imagine phpstan/phpstan is a hard dependency of a dependency.
I would expect it to be listed in packages then
15:24:45
@jtojnar:matrix.orgJan Tojnar
In reply to @drupol:matrix.org
Imagine phpstan/phpstan is a hard dependency of a dependency.
* I would expect it to be listed in packages section of composer.lock then
15:24:58
@drupol:matrix.orgPol How about using jq to nuke require-dev from composer.json and packages-dev from composer.lock ? :D 15:34:43
@drupol:matrix.orgPolI just pushed the changes in the branch.15:34:50
@drupol:matrix.orgPol The two working derivations are composer and phpunit. 15:35:01
@drupol:matrix.orgPol
In reply to @drupol:matrix.org
How about using jq to nuke require-dev from composer.json and packages-dev from composer.lock ? :D
I just tested this, it works pretty well actually.
16:09:41
@drupol:matrix.orgPolBuilding composer takes 1 minute now instead of 10 before16:11:45
@drupol:matrix.orgPol43 seconds actually.16:13:08
@drupol:matrix.orgPolOMG... It also fix psaln :D16:19:06
@drupol:matrix.orgPolGoing to commit all of this16:19:11
@drupol:matrix.orgPol * OMG... It also fix psalm :D 16:20:42
@drupol:matrix.orgPol Jan Tojnar Gaël Reyrol ^^ breakthrough ^^ 16:20:58
@drupol:matrix.orgPol
In reply to @drupol:matrix.org
How about using jq to nuke require-dev from composer.json and packages-dev from composer.lock ? :D
That seems to be actually a good idea !
16:21:23
@drupol:matrix.orgPolI just pushed everything :D16:21:41
@drupol:matrix.orgPolhttps://github.com/NixOS/nixpkgs/pull/232450/files#diff-8b7b6933957bf6ee2ddf23b376fe97a96708ced9cdaf1fcb26f452873a76723dR4116:22:15
@drupol:matrix.orgPol
    jq '."packages-dev" = []' composer.lock > newComposer.lock
    mv newComposer.lock composer.lock
    jq '."require-dev" = {}' composer.json > newComposer.json
    mv newComposer.json composer.json
16:22:24
@drupol:matrix.orgPolThat stuff fixed everything16:22:29
@drupol:matrix.orgPolI have the feeling that we finally see some light at the end of the tunnel.16:30:58
@drupol:matrix.orgPolI'm testing it here, I can't make it fail anymore!16:31:14

Show newer messages


Back to Room ListRoom Version: 6