| 1 Feb 2024 |
 Pol | I'm entering in a meeting, I'll check your replies later. | 13:18:27 |
 Jan Tojnar | In reply to @drupol:matrix.org
Jan Tojnar: shouldn't we do this instead (instead of the patch in https://github.com/NixOS/nixpkgs/pull/283175) ? https://github.com/NixOS/nixpkgs/pull/285542 That is a hacky workaround that might mask actual issues (especially when we add more patches). Patch is a more proper solution. | 13:20:24 |
| Jan Tojnar | And it is issue with Darwin just for now. It will be an issue everywhere once we bump gcc. | 13:21:13 |
| Pol | OK ! Fair enough. | 14:21:37 |
| Pol | Shall we continue with this PR then ? https://github.com/NixOS/nixpkgs/pull/283175 | 14:21:44 |
| Pol | The tests you ran this morning are green. | 14:21:58 |
| Jan Tojnar | Pol: would be also nice to check if fetchpatch cannot be used. | 16:53:24 |
| Pol | Jan Tojnar: Do we need 1 or 2 patches in https://github.com/NixOS/nixpkgs/pull/283175 | 16:57:51 |
| Jan Tojnar | One should be enough, just mention it in two places | 16:59:46 |
| Jan Tojnar | Or maybe we could reuse php patches in extensions using php src | 17:00:18 |
| Pol | My head is going to explode man... | 17:05:41 |
| Pol | So let's summarize a little bit | 17:07:56 |
| Pol | I would like to unblock nix-phps today if possible. | 17:08:07 |
| Pol | I've been dedicating a couple of hours to this, and I really wish I could do something else :) | 17:08:26 |
| Pol | So, for now, regarding this PR: https://github.com/NixOS/nixpkgs/pull/283175 | 17:08:44 |
| Pol | There's one simple patch, patching at the same time libxml and soap PHP extensions. | 17:09:05 |
| Pol | Tests seems to pass as seen on the PR. | 17:09:22 |
| Pol | Should we do something else? | 17:09:28 |
| Pol | I just pushed a commit to use the patch from php-src. | 17:28:39 |
| Pol | * I just pushed a commit to use the patch from github:php/php-src. | 17:28:55 |
| Jan Tojnar | Not a huge fan of the ellipsis, maybe removeAttrs fetchpatch from _attrs | 17:36:38 |
| Jan Tojnar | We can probably ignore soap for now since it is non-fatal | 17:39:04 |
| Pol | Right | 17:39:28 |
| Jan Tojnar | But it should be as easy as adding `patches = php.unwrapped.patches or [] ++ args.patches or []` to `mkExtension` in `php-packages.nix` | 17:42:05 |
| Pol | I removed the ellipsis | 17:43:27 |
| Pol | Now, what's left in there? | 17:43:52 |
| Pol | Jan Tojnar: Are you ok with this one ? https://github.com/NixOS/nixpkgs/pull/285511 | 18:32:35 |
| Jan Tojnar | In reply to @drupol:matrix.org
Jan Tojnar: Are you ok with this one ? https://github.com/NixOS/nixpkgs/pull/285511 Not really for me to decide, Nixpkgs PHP maintainers will bear the cost of extra code not needed for Nixpkgs | 18:53:22 |
| Pol | Ok but since I will most probably manage that, ... | 19:05:34 |
| Pol | I guess it's ok if I merge it ? | 19:05:40 |
