| 24 Apr 2023 |
 Pol | Nope sorry :S | 08:13:32 |
| Pol | Jan Tojnar: renamming buildComposerProject into mkComposerApp would make better sense? | 08:14:06 |
 Jan Tojnar | Pol: I think there can be more than just apps | 09:21:57 |
| Pol | Do you suggest a better naming? Or it is ok as it is ? | 09:34:39 |
| Jan Tojnar | I think buildComposerProject is good enough | 09:38:09 |
| Pol | Okidocky | 09:40:17 |
| Pol | Since it was a mkDerivation, I though naming it with mkSomething was a better option. | 09:40:38 |
| Pol | Jan Tojnar: I'm banging my head with psalm. Trying to understand why it's failing to be packaged with the new builder. | 18:33:04 |
| Pol | If you could give it a try... | 18:33:10 |
| Pol | Here's the derivation: | 18:33:15 |
| Pol | { lib, fetchFromGitHub, php }:
php.buildComposerProject (finalAttrs: {
pname = "psalm";
version = "5.9.0";
src = fetchFromGitHub {
owner = "vimeo";
repo = "psalm";
rev = finalAttrs.version;
hash = "sha256-yoDJPBoRaKGd78sJoQj26T3+x2QxbHAbH/lnbTJcnIM=";
};
# TODO: Open a PR against https://github.com/sebastianbergmann/phpunit
# Missing `composer.lock` from the repository.
composerLock = ./composer.lock;
vendorHash = "";
})
| 18:33:34 |
| Pol | It's failing during the composerSetupBuildHook | 18:33:51 |
| Pol | 
Download image.png | 18:34:19 |
| Pol | I just cannot find the reason why it's failing. | 18:34:30 |
| Pol | When I clone the project locally, this is working fine. | 18:34:38 |
| Jan Tojnar | Pol: 1.0.0+no-version-set looks suspicious | 19:02:55 |
| Pol | Yes, can't understand where it comes from | 19:20:09 |
| Pol | From composer that's sure, but why ?! | 19:22:51 |
| Pol | Found the issue. | 19:59:18 |
| Pol | COMPOSER_ROOT_VERSION="${version}" \ | 20:03:59 |
| Pol | https://github.com/NixOS/nixpkgs/blob/5ab2b1e0e1d9c3483371c93d20c08ecc1d1c4b5a/pkgs/development/php-packages/psalm/default.nix | 20:09:21 |
| Pol | Now it's fixed. | 20:09:25 |
| Pol | Amount of PHAR based software in Nix now: 1 (Composer) | 20:17:29 |
| Pol | and we're back to green. | 20:37:39 |
| Pol | Redacted or Malformed Event | 20:49:05 |
| Pol | Redacted or Malformed Event | 20:50:47 |
| Pol | Redacted or Malformed Event | 20:50:50 |
| 25 Apr 2023 |
| Pol | Jan Tojnar: Anything else to do for the PHP Builder branch? | 08:20:20 |
| Jan Tojnar | Pol: nothing comes to mind | 15:16:04 |
| Pol | Good news :D | 15:17:40 |
