| 18 May 2024 |
 jade_ | 
Download image.png | 04:00:58 |
| jade_ | O_o | 04:00:59 |
| jade_ | this is depraved code that we will have to retain compat for | 04:01:13 |
| jade_ | https://git.lix.systems/lix-project/lix/src/commit/7a3745b07607d3fc85fb5a0a08832ab078080884/src/libstore/remote-store.cc#L313-L315 | 04:01:26 |
| jade_ | wow | 04:01:27 |
 julia | it is certainly something | 04:05:47 |
| julia | it's also weird cause there's an InvalidPath() error and then it's not even used eveyrjwere | 04:06:22 |
| julia | * it's also weird cause there's an InvalidPathError and then there's also an InvalidPath, error, | 04:06:49 |
| jade_ | filed a bug that will permit deleting that code: https://git.lix.systems/lix-project/lix/issues/325 | 04:13:18 |
| julia | :) | 04:14:29 |
| julia | was gonna ask to do that because I was probbly not gonna do it | 04:14:39 |
| julia | lol daemon.cc is literred with checks of he protocol version less/more than 17 | 04:15:21 |
| julia | actually that seems to be checking for the thing with "backward" compat on the daemon side | 04:16:32 |
| julia | 
Download image.png | 04:17:10 |
| julia | (i was looking to see if had more info than just valid for remote store) | 04:17:25 |
| julia | * (i was looking to see if had more info than just valid for remote store, i think the answer is no) | 04:18:23 |
| julia | 
Download image.png | 04:25:08 |
| julia | uh so why is this trying to copy my version of the nixpkgs source to the remote store | 04:25:20 |
| julia | * uh so why is this trying to copy my version of the nixpkgs source to the remote store... and then eventually failing with 413 | 04:25:30 |
 Lunaphied | In reply to @jade_:matrix.org
https://git.lix.systems/lix-project/lix/src/commit/7a3745b07607d3fc85fb5a0a08832ab078080884/src/libstore/remote-store.cc#L313-L315 Aaaaa jade why would you do this now I've seen how bad the protocol serializing code is again | 04:45:52 |
| Lunaphied | (Seriously the fact Nix works at all is remarkable in the face of that code) | 04:47:58 |
| julia | I keep running into FIXME: concerning statement | 04:49:33 |
| julia | screams queryPathInfoUncached (virtual method on a base class) in some implementations returns nullptr for "not there" and others throws an error | 04:56:15 |
| julia | ... some of them even shell out to other functions and catch their invalid path errors | 04:58:35 |
| julia | * ... some of them even shell out to other functions and catch their invalid path errors so as to return nullptr | 04:58:50 |
 Qyriad | yeah. we have inherited a codebase from hell xP | 04:59:35 |
| julia | most seem to be returning nullptr... should I standardise on that? | 04:59:53 |
| Qyriad | absolutely, just carefully make sure the result behavior is still the same, and try to keep changes in a CL closely related | 05:01:50 |
| Qyriad | but we would absolutely love this fixed | 05:01:56 |
| julia | yep planning | 05:02:05 |
