| 24 Nov 2025 |
piegames | Uhm raitobezarius | 22:47:25 |
piegames | I appreciate you submitting these changes but they were not fully ready yet | 22:47:37 |
raitobezarius | Yes? | 22:47:40 |
piegames | lacking release notes for example | 22:47:44 |
piegames | and more tests | 22:47:50 |
piegames | (my bad for not marking them as draft) | 22:48:02 |
raitobezarius | Apologies for that, I was in a "submit routine" because too many changes are sent | 22:48:12 |
piegames | oh and also they were awaiting a flaker run :D | 22:48:24 |
raitobezarius | Next time, I won't touch your changes unless you give me an explicit request | 22:49:13 |
piegames | if not for the Flaker run I'd go with a fixup commit, but given that I currently don't even know if Nixpkgs still evaluates with them (probably?) I think a revert might be preferable | 22:49:36 |
raitobezarius | Do you think it's that time sensitive? | 22:50:02 |
piegames | I have no clue | 22:50:10 |
Rutile (Commentator2.0) feel free to ping | What happens when one pushes to a already merged cl? /cur | 22:50:13 |
raitobezarius | I can send a revert if you think so, but I'd imagine that we can be optimistic here | 22:50:15 |