!lymvtcwDJ7ZA9Npq:lix.systems

Lix Development

421 Members
(Technical) development of Lix, the package manager, a Nix implementation. Please be mindful of ongoing technical conversations in this channel.140 Servers

Load older messages


SenderMessageTime
21 Feb 2026
@rappolovich:matrix.orglolvich joined the room.23:34:43
22 Feb 2026
@yimi4:matrix.org@yimi4:matrix.org changed their display name from yimi to moved to @yimi:yinix.me.19:38:41
@yimi4:matrix.org@yimi4:matrix.org left the room.19:40:07
@raitobezarius:matrix.orgraitobezarius vczf FYI, Gerrit etiquette is that "ack" means "you read the comment but you are not addressing it" and "done" means "you read the comment and addressed it" usually 20:43:59
@raitobezarius:matrix.orgraitobezarius(it doesn't really matter a lot in practice because we can compare patchsets)20:44:32
@vczf:matrix.orgvczf
In reply to @raitobezarius:matrix.org
vczf FYI, Gerrit etiquette is that "ack" means "you read the comment but you are not addressing it" and "done" means "you read the comment and addressed it" usually
Should I have left it unresolved? Felt odd to leave it unacknowledged when it may be some time before I update the code
22:31:15
@ckie:ckie.devmei 🌒& changed their profile picture.22:54:40
@raitobezarius:matrix.orgraitobezarius
In reply to @vczf:matrix.org
Should I have left it unresolved? Felt odd to leave it unacknowledged when it may be some time before I update the code
Yeah it helps keep the "todo list" synced with your reviewer to leave unresolved if the code is non updated
23:15:45
@raitobezarius:matrix.orgraitobezariusIf you ack, your reviewer is the next one who needs to act23:16:01
@raitobezarius:matrix.orgraitobezariusWhen it should be you who should act 23:16:14
@vczf:matrix.orgvczfGotcha23:18:24
23 Feb 2026
@sky1e:mildlyfunctional.gaysky1e I think besadii had a spurious failure checking https://gerrit.lix.systems/c/lix/+/5250. Can someone poke it for me? 19:32:07
@sky1e:mildlyfunctional.gaysky1ety!20:08:31
24 Feb 2026
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)Would love to hear some thoughts on https://github.com/NixOS/nix/pull/15327. I recall chatting about symbol table order shenanigans and this seems to be an ok-ish solution to the f-ed up situation. Evaluation order already changes in practice, so making it more defined wouldn't be that bad I supppose?00:44:36
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)* Would love to hear some thoughts on https://github.com/NixOS/nix/pull/15327. I recall chatting about symbol table order shenanigans and this seems to be an ok-ish solution to the f-ed up situation. Evaluation order already changes in practice (and thus symbol table), so making it more defined wouldn't be that bad I supppose?00:44:57
@tiktorchic18:matrix.orgTikTorchic18 joined the room.03:47:34
@piegames:flausch.socialpiegamesAny alternative solutions to this?07:20:52
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)The only thing that comes to mind is to keep the status quo. One way or another some canonical order would have to be used I suppose. The cost of sorting doesn’t seem to matter that much, but there could be a way to amortise the cost by memoising the sorted order for commonly used attribute set shapes09:53:07
@k900:0upti.meK900Maybe it's time to make attrsets btreemaps after all09:53:53
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)
In reply to @k900:0upti.me
Maybe it's time to make attrsets btreemaps after all
Not sure about the memory usage there… They did use to be just a std::map before 2010 (circa 0.16)
09:54:45
@k900:0upti.meK900 I mean it shouldn't be that much bigger but it will also undo the stacking trick 09:55:14
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)TVL’s fork of 2.3 did play around with that too09:55:16
@k900:0upti.meK900I wonder if there's like A Paper somewhere09:56:39
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)
In reply to @k900:0upti.me
I mean it shouldn't be that much bigger but it will also undo the stacking trick
It would add quite a bit of pointer chasing even with a high degree of internal nodes too. And memory usage would probably jump by a lot. If the order is defined in the strings then lookup then also does string comparisons
09:57:25
@k900:0upti.meK900I mean btrees shouldn't be that pointer chasey09:58:06
@k900:0upti.meK900With big enough node sizes09:58:12
@k900:0upti.meK900I think the rustc people found that it's basically even perf wise09:58:32
@k900:0upti.meK900When rustc got switched from hashmaps to btreemaps in a bunch of places09:58:41
@k900:0upti.meK900For r11y09:58:43
@xokdvium:matrix.orgSergei Zimmerman (xokdvium)I mean, if somebody does the crazy and switches to be a better representation that’d be great. FWIW there’s an immutable CHAMP implementation in immer that connor baker tried using for attrsets10:04:28

Show newer messages


Back to Room ListRoom Version: 10