| 28 Oct 2023 |
adisbladis | It doesn't support them as a part of pep508 markers, but I don't think that's what we're talking about here. | 10:05:25 |
adisbladis | These are Python version constraints | 10:05:34 |
adisbladis | https://github.com/nix-community/poetry2nix/blob/master/mk-poetry-dep.nix#L151 needs to be swapped to the poetry specific one | 10:08:22 |
adisbladis | cpcloud: https://github.com/nix-community/poetry2nix/pull/1381 | 10:12:17 |
cpcloud | Nice, thanks | 10:13:03 |
cpcloud | I will add a test to that PR | 10:14:43 |
adisbladis | Gotta say I'm pretty happy about how that desugaring turned out | 10:14:45 |
cpcloud | It does look much nicer | 10:15:28 |
adisbladis | In reply to @pcloud:matrix.org I will add a test to that PR Sweet | 10:15:31 |
adisbladis | Thanks everyone <3 I feel like we're in a much better shape that we've been in in a very long time | 10:17:40 |
cpcloud | adisbladis: I added the test, it seems to fail in the same way 😕 | 10:23:28 |
adisbladis | In reply to @pcloud:matrix.org adisbladis: I added the test, it seems to fail in the same way 😕 Pushed another commit that fixes it =) | 10:26:43 |
cpcloud | Heh, of course it needs a build-systems fix. Incoming ... | 10:28:47 |
cpcloud | Ok, test succeeds locally. I set the PR to automerge! Thanks adisbladis | 10:34:18 |
adisbladis | Np =) | 10:34:59 |
cpcloud | Is there a way we roll sorting the build systems into the treefmt setup? | 10:35:02 |
cpcloud | * Is there a way we can roll sorting the build systems into the treefmt setup? | 10:35:07 |
adisbladis | I was just thinking about that earlier today. Should be trivial | 10:35:20 |
cpcloud | I keep having to copy paste the command from ci.yml :) | 10:35:24 |
cpcloud | Alright I'll give it a shot | 10:35:46 |
adisbladis | https://github.com/nix-community/poetry2nix/pull/1382 | 10:41:20 |
adisbladis | * cpcloud: https://github.com/nix-community/poetry2nix/pull/1382 | 10:41:43 |
cpcloud | Too fast for me | 10:42:19 |
adisbladis | ^_^ | 10:42:33 |
cpcloud | I was actually going to do | patch overrides/build-systems.json :) | 10:42:34 |
cpcloud | sponge looks neat, i've definitely wanted something like that before | 10:43:55 |
adisbladis | Yeah, pretty useful =) | 10:55:22 |
adisbladis | The next thing I'm unhappy about in poetry2nix is pep425.nix | 10:55:41 |
adisbladis | It's not super urgent but I intend to kill it off soon-ish | 10:55:51 |
cpcloud | This PR seems good to merge IMO https://github.com/nix-community/poetry2nix/pull/1298/ | 11:03:56 |