!rWxyQqNqMUDLECdsIf:blad.is

Poetry2nix

322 Members
https://github.com/nix-community/poetry2nix62 Servers

Load older messages


SenderMessageTime
28 Oct 2023
@adis:blad.isadisbladisIt doesn't support them as a part of pep508 markers, but I don't think that's what we're talking about here.10:05:25
@adis:blad.isadisbladisThese are Python version constraints10:05:34
@adis:blad.isadisbladishttps://github.com/nix-community/poetry2nix/blob/master/mk-poetry-dep.nix#L151 needs to be swapped to the poetry specific one10:08:22
@adis:blad.isadisbladis cpcloud: https://github.com/nix-community/poetry2nix/pull/1381 10:12:17
@pcloud:matrix.orgcpcloudNice, thanks10:13:03
@pcloud:matrix.orgcpcloudI will add a test to that PR10:14:43
@adis:blad.isadisbladisGotta say I'm pretty happy about how that desugaring turned out10:14:45
@pcloud:matrix.orgcpcloud It does look much nicer 10:15:28
@adis:blad.isadisbladis
In reply to @pcloud:matrix.org
I will add a test to that PR
Sweet
10:15:31
@adis:blad.isadisbladisThanks everyone <3 I feel like we're in a much better shape that we've been in in a very long time10:17:40
@pcloud:matrix.orgcpcloud adisbladis: I added the test, it seems to fail in the same way 😕 10:23:28
@adis:blad.isadisbladis
In reply to @pcloud:matrix.org
adisbladis: I added the test, it seems to fail in the same way 😕
Pushed another commit that fixes it =)
10:26:43
@pcloud:matrix.orgcpcloudHeh, of course it needs a build-systems fix. Incoming ...10:28:47
@pcloud:matrix.orgcpcloud Ok, test succeeds locally. I set the PR to automerge! Thanks adisbladis 10:34:18
@adis:blad.isadisbladisNp =)10:34:59
@pcloud:matrix.orgcpcloudIs there a way we roll sorting the build systems into the treefmt setup?10:35:02
@pcloud:matrix.orgcpcloud * Is there a way we can roll sorting the build systems into the treefmt setup?10:35:07
@adis:blad.isadisbladisI was just thinking about that earlier today. Should be trivial10:35:20
@pcloud:matrix.orgcpcloud I keep having to copy paste the command from ci.yml :) 10:35:24
@pcloud:matrix.orgcpcloudAlright I'll give it a shot10:35:46
@adis:blad.isadisbladishttps://github.com/nix-community/poetry2nix/pull/138210:41:20
@adis:blad.isadisbladis * cpcloud: https://github.com/nix-community/poetry2nix/pull/1382 10:41:43
@pcloud:matrix.orgcpcloudToo fast for me10:42:19
@adis:blad.isadisbladis^_^10:42:33
@pcloud:matrix.orgcpcloud I was actually going to do | patch overrides/build-systems.json :) 10:42:34
@pcloud:matrix.orgcpcloud sponge looks neat, i've definitely wanted something like that before 10:43:55
@adis:blad.isadisbladisYeah, pretty useful =)10:55:22
@adis:blad.isadisbladisThe next thing I'm unhappy about in poetry2nix is pep425.nix10:55:41
@adis:blad.isadisbladisIt's not super urgent but I intend to kill it off soon-ish10:55:51
@pcloud:matrix.orgcpcloudThis PR seems good to merge IMO https://github.com/nix-community/poetry2nix/pull/1298/11:03:56

Show newer messages


Back to Room ListRoom Version: 6