!sBfrWMVsLoSyFTCkNv:nixos.org

OfBorg

176 Members
Number of builds and evals in queue: <TBD>61 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
9 Jan 2022
@winterqt:nixos.devWinter (she/her) joined the room.00:59:15
@winterqt:nixos.devWinter (she/her)If a module has no maintainers set, does OfBorg pick a reviewer at random?00:59:37
@hexa:lossy.networkhexahttps://github.com/NixOS/ofborg/issues/56801:02:45
@hexa:lossy.networkhexahttps://github.com/NixOS/nixpkgs/pull/12844701:02:53
@piegames:matrix.orgpiegamesModule maintainers are not pinged at all, regardless of maintainers (:01:03:05
@winterqt:nixos.devWinter (she/her)Noted — what are they used for, then?01:13:40
@piegames:matrix.orgpiegamesIdeally, for pinging the reponsible people. At the moment, nothing I would know of. If you edit a module you'll know whom to ping, I guess01:19:48
@hexa:lossy.networkhexa
In reply to @winterqt:nixos.dev
Noted — what are they used for, then?
wishful thinking
01:20:03
@hexa:lossy.networkhexaexpectation of a glorious future01:20:09
@winterqt:nixos.devWinter (she/her)heh01:21:15
@winterqt:nixos.devWinter (she/her)so it’s still a good idea to keep them up to date?01:21:27
@hexa:lossy.networkhexaif you want to get pinged use the CODEOWNERS feature instead01:21:40
@hexa:lossy.networkhexathough that only works if you have commit access01:21:45
@piegames:matrix.orgpiegames
In reply to @winterqt:nixos.dev
so it’s still a good idea to keep them up to date?
Yes
01:21:48
@winterqt:nixos.devWinter (she/her)
In reply to @hexa:lossy.network
though that only works if you have commit access
yeah, since I don’t I figured that would be the next best thing
01:22:08
@winterqt:nixos.devWinter (she/her)is there any reason we currently don’t take them into account for automated pinging/assigning other than we just don’t atm?01:22:36
@hexa:lossy.networkhexathere is an example of how to collect meta.maintainers from modules in that ofborg issue01:23:02
@hexa:lossy.networkhexasomeone needs to implement the feature01:23:10
@hexa:lossy.networkhexaIMO the foundation should support ofBorg with money01:23:26
@winterqt:nixos.devWinter (she/her)tbh i might dedicate time to implementing it, if i can get a grasp for ofborg’s codebase01:24:02

Show newer messages


Back to Room ListRoom Version: 6