| 19 Sep 2023 |
@delroth:delroth.net | ahhh | 22:00:16 |
@delroth:delroth.net | ok, that's what confused me, thanks | 22:00:25 |
cole-h | Yes, that's because GHA cannot trigger on bot-created PRs | 22:00:28 |
Lily Foster | (And GHAs don't get run by default for PRs opened by a github token) | 22:00:31 |
cole-h | Nixpkgs takes 10+ minutes to eval these days, so, yeah 🙃 | 22:00:46 |
@delroth:delroth.net | for some reason I never noticed that peculiarity before, thanks | 22:00:47 |
cole-h | The workaround most people employ is to open-and-close the PR, which will start GHA | 22:00:58 |
Lily Foster | In reply to @cole-h:matrix.org Yes, that's because GHA cannot trigger on bot-created PRs I thought you could trigger it manually? Just as an actions workflow_dispatch | 22:01:06 |
cole-h | Maybe, I've never tried :P | 22:01:29 |
Artturin | I created a issue for it in 2021 https://github.com/NixOS/nixpkgs/issues/148482 | 22:01:58 |
Artturin | * I created a issue checking backport prs in 2021 https://github.com/NixOS/nixpkgs/issues/148482 | 22:02:12 |
Artturin | * I created a issue about checking backport prs in 2021 https://github.com/NixOS/nixpkgs/issues/148482 | 22:02:19 |
Lily Foster | Regardless the point being it would require an additional thing on our part to start GHAs on PRs created by our backport workflow | 22:02:22 |
Lily Foster | We actually don't run actions at all even on manual PRs iirc since for some reason we decided to exclude PRs to release branches on our github actions.... (ofborg still runs but again it just gets queued at the webhook and takes a while to actually start eval depending on queue size) | 22:03:55 |
Lily Foster | * We actually don't run actions at all even on manual backport PRs iirc since for some reason we decided to exclude PRs to release branches on our github actions.... (ofborg still runs but again it just gets queued at the webhook and takes a while to actually start eval depending on queue size) | 22:04:04 |
| 21 Sep 2023 |
| dedmunwalk joined the room. | 23:08:45 |
| 22 Sep 2023 |
| K900 changed their profile picture. | 09:53:50 |
| 26 Sep 2023 |
| emily changed their display name from Emily to emily. | 16:47:58 |
| 29 Sep 2023 |
@asymmetric:matrix.dapp.org.uk | is it possible to increase the timeout for a specific (platform, package) pair? polkadot has been timing out on darwin for quite a while:
- https://github.com/NixOS/nixpkgs/pull/244483/checks?check_run_id=15298342100
- https://github.com/NixOS/nixpkgs/pull/239325/checks?check_run_id=14499669290
- https://github.com/NixOS/nixpkgs/pull/257419/checks?check_run_id=17145741624
| 09:07:39 |
K900 | meta.timeout | 09:08:19 |
@asymmetric:matrix.dapp.org.uk | huh interesting, where is it defined in nixpkgs? can't see it in lib/meta.nix | 09:09:58 |
@asymmetric:matrix.dapp.org.uk | here?
https://github.com/NixOS/nixpkgs/tree/4a359e2106bc1eb23d9c99837e8f1ecb90453f3e/pkgs/stdenv/generic/check-meta.nix#L291 | 09:11:33 |
@asymmetric:matrix.dapp.org.uk | i assume it represents minutes? | 09:11:46 |
K900 | Seconds IIRC? | 09:15:01 |
@piegames:matrix.org | I hate meta attributes from the bottom of my heart | 09:16:52 |
@asymmetric:matrix.dapp.org.uk | In reply to @piegames:matrix.org I hate meta attributes from the bottom of my heart why? | 09:18:00 |
@piegames:matrix.org | Because they are under- or undocumented, barely checked, and generally an unstructured free-for-all. | 09:21:19 |
@piegames:matrix.org | * Because they are under- or undocumented, barely checked, not discoverable, and generally an unstructured free-for-all. | 09:21:36 |
@asymmetric:matrix.dapp.org.uk | seems that:
- it's seconds
- hydra sets a default of 10 hrs?
https://github.com/NixOS/hydra/blob/master/src/hydra-eval-jobs/hydra-eval-jobs.cc#L195
| 09:24:28 |
@asymmetric:matrix.dapp.org.uk | so if i set it to e.g. 2 hours for ofborg i'd actually be lowering relative to the default for hydra? | 09:25:34 |