| 18 Sep 2023 |
 Dandellion | I think Ma27 seemed quite negative about this generally, But personally I think just putting the maps inside services.nginx.commonHttpConfig is more than adequate even without RFC-42 nginx (Which I think is basically impossible without introducing some kind of DAG system similar to home-manager)
But I'll be changing my module to match the nixpkgs implementation and work towards upstreaming the autoconfig stuff
| 18:01:57 |
 hexa | I think it is much more straightforward than nextcloud 😄 | 18:02:44 |
| hexa | and maintaining the map in nixpkgs would require a fair amount of testing and attention when updating the package | 18:03:22 |
| Dandellion | worst case it just falls back to the main process | 18:03:51 |
| Dandellion | it'd be additive in any case really | 18:04:04 |
| hexa | Oh yeah, that should work for most cases, except for enable_media_repo = false or send_federation = false | 18:04:43 |
| hexa | also stream writers are a bit more complex with the different types they can be configured to handle | 18:05:58 |
| Dandellion | stream writers are problematic yep | 18:06:17 |
| Dandellion | or, at least, slightly annoying | 18:06:31 |
| hexa | events can be striped across multiple workers, most other things (typing, to_device, account_data, receipts, presence) cannot | 18:07:06 |
| hexa | synapse will fail to boot when you configure a list where it expects a string, ask me how I know | 18:07:55 |
| hexa | * synapse will fail to boot when you configure a list of workers where it expects a just a single one, ask me how I know | 18:08:13 |
| Dandellion | that's right, it's also why my module only supports event persisters for now | 18:09:00 |
 ma27 | In reply to @hexa:lossy.network
synapse will fail to boot when you configure a list of workers where it expects a just a single one, ask me how I know oh, you too :D | 18:09:04 |
| ma27 | currently on the phone, will respond later | 18:09:16 |
| Dandellion | since abstracting the other stream writers required a little more work at the time | 18:09:33 |
| Dandellion | * since abstracting the other stream writers properly required a little more work at the time | 18:09:45 |
| hexa | as the worker setup is very brittle, we should probably try to co-maintain most of the thing | 18:12:06 |
| hexa | * as the worker setup is very brittle, we should probably try to co-maintain most of the code | 18:12:12 |
