| 31 Dec 2021 |
|  Zhaofeng Li joined the room. | 04:44:03 |
| 3 Jan 2022 |
|  ckie (they/them) joined the room. | 12:31:34 |
| 4 Jan 2022 |
|  net-mist joined the room. | 16:24:12 |
| 5 Jan 2022 |
 @grahamc:nixos.org | it strikes me the tracker support for Hydra could be used to inject additional features | 17:56:50 |
| @grahamc:nixos.org | * it strikes me the tracker support for Hydra could be used to inject additional features that don't make sense to be part of hydra | 17:57:14 |
| @grahamc:nixos.org | 
Download image.png | 18:03:10 |
| @grahamc:nixos.org | for example | 18:03:12 |
| @grahamc:nixos.org | https://github.com/NixOS/hydra/pull/1089 👍️ | 20:35:56 |
| 7 Jan 2022 |
| @grahamc:nixos.org | das_j: re https://github.com/NixOS/hydra/pull/1062 do you think it is important to not show this information without opting in to it? I'm inclined to merge it as-is, and if someone is putting secrets in their runcommand ... they probably shouldn't ... | 20:21:20 |
| @grahamc:nixos.org | and that I'd rather them change than to add a feature flag that we need to support | 20:21:31 |
| @grahamc:nixos.org | ^ I'm open to other people's feedback too of course | 21:02:20 |
 ajs124 | why shouldn't we put secrets in runcommand? or do you mean the output of runcommand? | 21:20:06 |
| @grahamc:nixos.org | in the actual command being executed? | 21:26:13 |
| @grahamc:nixos.org | I would expect secrets to be passed in via a file or something, not part of the actual command being executed | 21:29:47 |
| @grahamc:nixos.org | ajs124: just to confirm, do you have a runcommand hook where the actual program executed is a secret? | 21:30:57 |
| @grahamc:nixos.org | * ajs124: just to confirm, do you have a runcommand hook where the actual program and its arguments executed is a secret? | 21:31:07 |
| @grahamc:nixos.org | * ajs124: just to confirm, do you have a runcommand hook where the actual program and its arguments executed areis a secret? | 21:31:10 |
| @grahamc:nixos.org | * ajs124: just to confirm, do you have a runcommand hook where the actual program and its arguments executed are a secret? | 21:31:12 |
| ajs124 | I don't, but I wouldn't be surprised if somebody did | 21:31:20 |
| ajs124 | It doesn't seem that unreasonable | 21:31:31 |
| ajs124 | In reply to @grahamc:nixos.org
I would expect secrets to be passed in via a file or something, not part of the actual command being executed this, we have | 21:31:38 |
| @grahamc:nixos.org | right | 21:31:46 |
| @grahamc:nixos.org | do you think it is a mistake to skip disabling this tab? | 21:32:42 |
| ajs124 | skip disabling meaning always enabling it? | 21:33:55 |
| ajs124 | it's probably fine. people be running hydra, so they know what they got themselves into. | 21:34:14 |
| ajs124 | which remindes me, hydra-eval-jobs started segfaulting for us yesterday and I haven't figured out why, yet. | 21:34:31 |
| @grahamc:nixos.org | yeah, always enabling it. if you use runcommand you get the tab | 21:34:35 |
| @grahamc:nixos.org | ouch | 21:34:37 |
| @grahamc:nixos.org |
know what they got themselves into
| 21:34:56 |
| @grahamc:nixos.org | I agree | 21:35:03 |
