| 13 Feb 2023 |
abathur | le sigh | 21:13:11 |
abathur | * le sigh | 21:13:34 |
Ana | What's wrong, abathur ? | 21:59:50 |
abathur | someone's opened a chonky WIP installer PR | 22:01:30 |
| 14 Feb 2023 |
@grahamc:nixos.org | link? | 16:37:56 |
@grahamc:nixos.org | https://github.com/NixOS/nix/pull/7827 oh dear | 16:39:02 |
abathur | not sure about quality of the instructions, but spotted this on reddit https://github.com/dnkmmr69420/nix-with-selinux under the title "I got nix working with selinux on silverblue" | 21:34:06 |
Zhaofeng Li | In reply to @grahamc:nixos.org https://github.com/NixOS/nix/pull/7827 oh dear This would look much less chunky if the author didn't insist on reformatting everything 🤨 | 22:38:13 |
Zhaofeng Li | But based on the PR description, they don't appear to be receptive to feedback suggesting otherwise:
this is an objective readability improvement not a style-preference change.
| 22:39:52 |
Matthew Kenigsberg | In reply to @zhaofeng:zhaofeng.li This would look much less chunky if the author didn't insist on reformatting everything 🤨 I feel like a good first suggestion might be to split out stuff like that into it's own PR | 22:48:22 |
abathur | I had a bit of a bizarre exchange with them before they started working on this in an issue, starting at https://github.com/NixOS/nix/issues/3900#issuecomment-1268329909 | 23:06:14 |