1 Nov 2024 |
abathur | * Looking at this now. Good news, I think.
It looks like the workflow that updates prerelease ~would have automatically picked up our May bump if we hadn't clobbered hydraJobs.build in the process :)
https://github.com/NixOS/experimental-nix-installer/commit/4993d8c94679087033ed9df327e44ac4773df38b#diff-206b9ce276ab5971a2489d75eb1b12999d4bf3843b7988cbe8d687cfde61dea0L208
I should be able to restore that easily enough as long as the builds succeed, but I'm hoping Matthew Kenigsberg can take a peek and maybe remember if there was a reason to drop the attr or if this was just an oops during conflict resolution?
(Eval ran okay when I pointed hydra at a fix branch; not sure how quickly it will get to the first build. It looks like the "Generate Installer Script" job got disabled for 60-days of repo inactivity in September, so it won't automatically start picking up the new eval until we enable it. I'm building #.hydraJobs.build.x86_64-darwin locally as a sanity check but I don't think it'll fail.)
| 15:17:26 |
abathur | Maybe also worthwhile to set up a check that'll actually break if we bork it again, though it might also be good if the "Generate Installer Script" job itself can start failing in this condition since technically the hydra evals could stop coming without a new commit. Not sure off the top of my head what that'd have to look like though. | 15:24:17 |
abathur | My local build succeeded and aarch64-linux succeeded on hydra already, so I imagine this'll work as long as there wasn't a reason to drop the attr | 16:12:30 |
Matthew Kenigsberg | I think I probably just missed that when I did the merge, sorry about that | 22:28:30 |
2 Nov 2024 |
abathur | no worries | 00:15:31 |
abathur | I'll re-enable the workflow once hydra finishes | 00:15:43 |
abathur | well, I'll try to remember to :] | 00:16:22 |
5 Nov 2024 |
abathur | In reply to @abathur:matrix.org well, I'll try to remember to :] did it | 03:10:12 |
| willbush joined the room. | 06:46:26 |
abathur | it has been running, but I suspect I missed something since the workflow runs haven't committed anything else onto the prerelease branch | 14:31:37 |
6 Nov 2024 |
abathur | Domen Kožar: Cole identified the bug in assemble_installer.py that was keeping it from updating, but the scheduled workflow now fails when the git-auto-commit action tries to check out the prerelease branch because the branch now has a set of binary files that conflict with the uncommitted copies that the workflow has built against main .
Well beyond out of time to poke at it for the day, so I'm hoping you can take a look :)
| 16:37:54 |
abathur | Here's the CI run: https://github.com/NixOS/experimental-nix-installer/actions/runs/11707608503/job/32607383674 | 16:38:22 |
abathur | re-disabling the workflow for now | 17:52:24 |
7 Nov 2024 |
abathur | Since domen doesn't seem to have noticed the mention here, I'm trying opening an issue and assigning it to him: https://github.com/NixOS/experimental-nix-installer/issues/19 | 14:36:35 |
13 Nov 2024 |
| inayet joined the room. | 22:17:10 |
19 Nov 2024 |
Matthew Kenigsberg | abathur: I'm taking a look at that issue, could you merge https://github.com/NixOS/experimental-nix-installer/pull/20 or give me permissions to do so? | 18:05:52 |
Matthew Kenigsberg | And I guess could you re-enable the job for a bit or give me permissions to do so? | 18:08:49 |
abathur | Merged and enabled | 18:20:13 |
Matthew Kenigsberg | Thanks! Do you see the Run workflow dropdown at https://github.com/NixOS/experimental-nix-installer/actions/workflows/release-script.yml? I'm not seeing it. Wondering if I don't have permissions | 18:22:56 |
abathur | I do | 18:32:21 |
abathur | I don't see any collaborator settings so I think I also lack the keys to delegate that, but I started it now and can do so as often as I notice a ping I guess | 18:37:31 |
abathur | You probably wanted me to run it on a branch though? | 18:38:30 |
Matthew Kenigsberg | Was hoping to do a test run on flox:fix-release. Although now I'm realizing I don't even have permissions to push to a branch in the repo. Not sure if we should get permissions sorted or you should push to a branch or we should just merge and hack on main...? Idk | 18:39:13 |
abathur | * You probably wanted me to run it on another branch though? | 18:39:16 |
abathur | Lol | 18:39:29 |
Matthew Kenigsberg | Do you know who I would ask for permissions? | 18:39:51 |
abathur | I think @graham:grahamc.com might have set mine up | 18:43:18 |
abathur | I am not very plugged in at that level of the org. Certainly others as well, maybe @hexa:lossy.network here or ask in the infra room? | 18:48:25 |
abathur | @domenkozar:matrix.org I guess since he committed to the repo directly | 18:48:54 |
hexa | #org_owners:nixos.org | 18:50:41 |