Nix NodeJS | 202 Members | |
| 58 Servers |
| Sender | Message | Time |
|---|---|---|
| 30 Apr 2024 | ||
In reply to @lily:lily.flowersi wonder if it's because the composer stuff changes build to that dir first | 21:02:06 | |
| if it's working now, leave it as-is then :) | 21:02:13 | |
Yeah, maybe even the other way around. In the logs I see first the npm runs and then composer>
sure 😄
If you are interested, I can make a new branch with the change. It's my open source project anyway | 21:04:59 | |
*
Yeah, maybe even the other way around. In the logs I see first the npm runs and then composer.
sure 😄
If you are interested, I can make a new branch with the change. It's my open source project anyway | 21:05:17 | |
In reply to @matejam:matrix.orgnah, i'm pretty sure it's because composer changes dir and you want npm to run after that. so you're doing it right enough and this looks pretty awesome actually :) | 21:05:34 | |
| it feels neat that you are able to mix the npm hooks into another builder without too much fuss and have a multi-language-package-manager app build in a derivation like that | 21:06:10 | |
In reply to @c0ba1t:matrix.orgoooof. well marsam left and i'm recovering from surgery, so someone else will probably have to bump the nodejs derivation | 21:09:32 | |
In reply to @lily:lily.flowers(no one else is on nodejs team rn except winter who also hasn't had time for things....) | 21:10:15 | |
Yeah, Composer also has it's own version of fetchNpmDeps (mkComposerRepository) but I couldn't really make it work. I don't know how it would handle 3 or more language app builds 😂 I'm glad that it works for 2 | 21:10:14 | |
In reply to @lily:lily.flowersIt looks like the fix for the upstream issue was merged today. Though, by the comments on the MR, it will likely take a bit until a patch release will be published. So there's no need to hurry here. | 21:27:35 | |