| 18 Nov 2023 |
 Cobalt | Are the results in any way surprising? The cputime looks a bit too small to be used for reliable measurements without perf counters | 10:41:33 |
 @adis:blad.is | Not surprising to me. I was expecting it to be a bit faster and use less memory
I'm not overly concerned with exact wall time, I'm OK concluding it's a bit faster and leave it at that. | 11:11:13 |
| @adis:blad.is | A concern that often comes up when when talking about lock file parsing in nixpkgs performance.
I wanted to have ballpark numbers to refer to. | 11:12:52 |
| Cobalt | Ah, okay. Thank you for sharing | 11:13:31 |
 raitobezarius | In reply to @adis:blad.is
A concern that often comes up when when talking about lock file parsing in nixpkgs performance.
I wanted to have ballpark numbers to refer to. You know that I nerdsnipped @tomberek on adding the parsing built-in based on a EBNF grammar (a packrat parser) | 11:48:39 |
| raitobezarius | He got OK speed I think | 11:48:46 |
| raitobezarius | But he uncovered a quadratic issue with Nix strings | 11:48:54 |
| raitobezarius | Because substr is linear all the time as strings in Nix doesn't really know their own length | 11:49:14 |
| @adis:blad.is | Huh | 11:49:28 |
| @adis:blad.is | In reply to @raitobezarius:matrix.org
You know that I nerdsnipped @tomberek on adding the parsing built-in based on a EBNF grammar (a packrat parser) That would be cool to have. | 11:50:50 |
| @adis:blad.is | But for this case you really don't need fancy parsing, you just need json | 11:51:00 |
| raitobezarius | But gigabyte/s JSON parsing:> | 12:00:28 |
| raitobezarius | Idk how fast is our JSON library | 12:00:43 |
| @adis:blad.is | Fatet than our nix parser :p | 12:06:05 |
| @adis:blad.is | * Faster than our nix parser :p | 12:08:01 |
| @adis:blad.is | After some further refactoring:
{
"cpuTime": 0.34559598565101624,
"envs": {
"bytes": 6537216,
"elements": 330112,
"number": 243520
},
"gc": {
"heapSize": 402915328,
"totalBytes": 63767152
},
"list": {
"bytes": 985672,
"concats": 9249,
"elements": 123209
},
"nrAvoided": 358263,
"nrFunctionCalls": 218872,
"nrLookups": 82272,
"nrOpUpdateValuesCopied": 1712032,
"nrOpUpdates": 18283,
"nrPrimOpCalls": 171800,
"nrThunks": 461439,
"sets": {
"bytes": 33342256,
"elements": 2027794,
"number": 56097
},
"sizes": {
"Attr": 16,
"Bindings": 16,
"Env": 16,
"Value": 24
},
"symbols": {
"bytes": 246484,
"number": 24916
},
"values": {
"bytes": 13269240,
"number": 552885
}
}
| 13:24:25 |
| @adis:blad.is | I mainly did it for improved UX, but that was a sweet bonus. | 13:24:56 |
| @adis:blad.is | It looks much more similar to fetchNpmDeps in usage now | 13:29:54 |
| 19 Nov 2023 |
|  ZXGU joined the room. | 11:02:39 |
| 20 Nov 2023 |
 Wanja Hentze | In reply to @adis:blad.is
Cool :) Hah, it doesn't work (at least not out of the box) but not for the reasons I was thinking of | 16:08:31 |
| Wanja Hentze | we have a .npmrc to do bearer auth against a private gitlab registry and we hacked support for that into our npmlock2nix fork | 16:09:10 |
| Wanja Hentze | after porting that over (in an even hackier manner), the next issue seems to be that we have packageRoot != src. That makes the npm-config-hook.sh unhappy. Looks like it's being run in src, not in packageRoot for some reason. | 17:04:37 |
| Wanja Hentze | debugging a little bit, I found that $npmRoot is not set at this point: https://github.com/adisbladis/buildNodeModules/blob/master/hooks/npm-config-hook.sh#L6 | 17:09:42 |
| Wanja Hentze | am I still expected to pass sourceRoot to mkDerivation for this to work? | 17:17:07 |
| Wanja Hentze | so atm I have 2 questions adisbladis
- if I cleaned up the code to parse
.npmrc and pass auth headers based on it into fetchurl, would you be willing to take it?
- is
src != packageRoot supposed to work, or is it an unsupported configuration?
| 17:30:49 |
| Wanja Hentze | the src/sourceRoot/npmRoot/packageRoot situation is quite confusing to me. no combination I've tried seems to work. | 17:46:59 |
| 21 Nov 2023 |
 ris_ | fetchYarnDeps is failing for me with unable to get local issuer certificate for basically everything | 21:57:51 |
 Lily Foster | In reply to @r_i_s:matrix.org
fetchYarnDeps is failing for me with unable to get local issuer certificate for basically everything https://github.com/NixOS/nixpkgs/pull/269061 | 22:12:57 |
| 22 Nov 2023 |
|  thiloho set a profile picture. | 14:58:10 |
 hexa | offline> building '/nix/store/646wyw911xp06k2lpjz6fdiwfwbq00il-offline.drv'
offline> patching sources
offline> updateAutotoolsGnuConfigScriptsPhase
offline> configuring
offline> no configure script, doing nothing
offline> building
offline> SyntaxError: Unknown token: { line: 3, col: 2, type: 'INVALID', value: undefined } 3:2 in lockfile
offline> at Parser.unexpected (/nix/store/z58x3lknjdhqkph4s95bk6y24xz9a0a8-prefetch-yarn-deps/libexec/yarnpkg-lockfile.js:5064:11)
offline> at Parser.parse (/nix/store/z58x3lknjdhqkph4s95bk6y24xz9a0a8-prefetch-yarn-deps/libexec/yarnpkg-lockfile.js:5193:14)
offline> at parse (/nix/store/z58x3lknjdhqkph4s95bk6y24xz9a0a8-prefetch-yarn-deps/libexec/yarnpkg-lockfile.js:5262:17)
offline> at module.exports.exports.default (/nix/store/z58x3lknjdhqkph4s95bk6y24xz9a0a8-prefetch-yarn-deps/libexec/yarnpkg-lockfile.js:4835:96)
offline> at prefetchYarnDeps (/nix/store/z58x3lknjdhqkph4s95bk6y24xz9a0a8-prefetch-yarn-deps/libexec/index.js:135:28)
offline> at main (/nix/store/z58x3lknjdhqkph4s95bk6y24xz9a0a8-prefetch-yarn-deps/libexec/index.js:189:9)
| 15:11:18 |
