| 31 Oct 2023 |
 Lily Foster | In reply to @lily:lily.flowers
(and i have a lot of open PRs I can't convince anyone to review 🙈) (if any committers want to go over any of my PRs in this list, especially the backports to 23.05, that, um, would be nice 👉️👈️: https://github.com/orgs/NixOS/projects/37/views/1) | 12:12:42 |
 Emma [it/its] ⚡️ | bottom moment /j | 12:15:21 |
| Emma [it/its] ⚡️ | thats one large board o.o | 12:15:37 |
 Cobalt | In reply to @lily:lily.flowers
(if any committers want to go over any of my PRs in this list, especially the backports to 23.05, that, um, would be nice 👉️👈️: https://github.com/orgs/NixOS/projects/37/views/1) Tbh, it's easier to overlay the patch instead of waiting for nixpkgs: https://git.tu-berlin.de/nix/songbird/-/blob/main/modules/prefetch-fix.nix?ref_type=heads just a few lines + a tmp input | 12:19:09 |
| Lily Foster | In reply to @c0ba1t:matrix.org
Tbh, it's easier to overlay the patch instead of waiting for nixpkgs: https://git.tu-berlin.de/nix/songbird/-/blob/main/modules/prefetch-fix.nix?ref_type=heads just a few lines + a tmp input i mean i could hit merge myself, but i have too much anxiety to self-merge | 12:20:23 |
| Lily Foster | (even self-merging approved backports after i broke 23.05 the very first time i did that for a backport i made that got several approvals like a week after getting committer access...........) | 12:20:53 |
| Cobalt | In reply to @lily:lily.flowers
(even self-merging approved backports after i broke 23.05 the very first time i did that for a backport i made that got several approvals like a week after getting committer access...........) Interesting, wasn't the Borg bot supposed to prevent something like this? | 12:26:57 |
| Lily Foster | In reply to @c0ba1t:matrix.org
Interesting, wasn't the Borg bot supposed to prevent something like this? now that is a whole conversation where i tried to fix the ci to avoid that occuring to anyone else and got told we can't have nice things | 12:28:05 |
| Cobalt | In reply to @lily:lily.flowers
i mean i could hit merge myself, but i have too much anxiety to self-merge That's understandable, no pressure. Iirc nixpkgs guidelines also discouraged want self-merged MRs | 12:28:09 |
| Cobalt | * In reply to @lily:lily.flowers
i mean i could hit merge myself, but i have too much anxiety to self-merge
That's understandable, no pressure. Iirc nixpkgs guidelines also discouraged self-merged MRs | 12:28:39 |
| Lily Foster | In reply to @lily:lily.flowers
now that is a whole conversation where i tried to fix the ci to avoid that occuring to anyone else and got told we can't have nice things (i'm oversimplifying and misrepresenting slightly here, but that is the gist of it) | 12:28:43 |
| Lily Foster | In reply to @c0ba1t:matrix.org
In reply to @lily:lily.flowers
i mean i could hit merge myself, but i have too much anxiety to self-merge
That's understandable, no pressure. Iirc nixpkgs guidelines also discouraged self-merged MRs i mean if it has approvals it's not really frowned upon, but i still just have too much anxiety after last time 😅 | 12:34:52 |
|  @joepie91:pixie.town joined the room. | 19:34:05 |
| * @joepie91:pixie.town beeps | 19:35:38 |
| Lily Foster | In reply to @joepie91:pixie.town
beeps meow | 19:37:38 |
| @joepie91:pixie.town | Lily Foster: I will probably forget to pay attention to this channel, so if there's a question that you need my input on, pinging me will generally work best :p | 19:38:18 |
| Lily Foster | In reply to @joepie91:pixie.town
Lily Foster: I will probably forget to pay attention to this channel, so if there's a question that you need my input on, pinging me will generally work best :p will do, thank you so much! ❤️ | 19:38:48 |
| @joepie91:pixie.town | np :) | 19:39:02 |
|  Wanja Hentze joined the room. | 19:39:47 |
| Wanja Hentze | joepie91 🏳️🌈: so which of the ~dozen or so npm/nix things should I use | 19:40:52 |
| Wanja Hentze | so far I've tried
- node2nix
- buildNpmPackage (from nixpkgs)
- buildNpmPackage (from serokell)
- old v1-only npmlock2nix
- newer npmlock2nix
- floco
- napalm
- dream2nix
| 19:42:10 |
| Lily Foster | what do you mean from serokell.... do they have their own? | 19:42:37 |
| Wanja Hentze | yes | 19:43:13 |
| Wanja Hentze | just accidentally named the same, no relation from what I can tell | 19:43:28 |
| Lily Foster | In reply to @whentze:matrix.org
just accidentally named the same, no relation from what I can tell ah interesting. i missed that then | 19:43:43 |
| Wanja Hentze | https://github.com/serokell/nix-npm-buildpackage | 19:43:52 |
 Marie | In reply to @whentze:matrix.org
joepie91 🏳️🌈: so which of the ~dozen or so npm/nix things should I use i had the best experience with buildNpmPackage (nixpkgs) so far, but didn't try all of the things you said | 19:45:34 |
| Lily Foster | i'm biased, so i won't answer... | 19:45:53 |
| Wanja Hentze | we also have a private fork of oldschool npmlock2nix at work which works for all our cursed crap | 19:45:58 |
| Wanja Hentze | In reply to @lily:lily.flowers
i'm biased, so i won't answer... no please shill your tool | 19:46:08 |
