Nix NodeJS - Public Room Timeline

	Nix NodeJS	209 Members
		59 Servers

Load older messages

Sender	Message	Time
8 Aug 2023
countoren	hi guys I actually took couple of branches here: buildNpmPackage - could not pass the 401 of the fortawosme package, what will be the way to go with the pre-downloaded tars here? node2nix - override sources in node-packages with the tars i downloaded with npm pack, but now I reached another block that when I overriding the package drv and adding postInstall and buildInputs for ng I am getting : ``` Error: Could not find the '@angular-devkit/build-angular:browser' builder's node package.	23:48:51
countoren	* hi guys I actually took couple of branches here: buildNpmPackage - could not pass the 401 of the fortawosme package, what will be the way to go with the pre-downloaded tars here? node2nix - override sources in node-packages with the tars i downloaded with npm pack, but now I reached another block that when I overriding the package drv and adding postInstall and buildInputs for ng I am getting : `Error: Could not find the '@angular-devkit/build-angular:browser' builder's node package.`	23:49:33
countoren	* hi guys I actually took couple of branches here: buildNpmPackage - could not pass the 401 of the fortawosme package, what will be the way to go with the pre-downloaded tars here? node2nix - override sources in node-packages with the tars i downloaded with npm pack, but now I reached another block that when I overriding the package drv and adding postInstall and buildInputs for ng I am getting : `Error: Could not find the '@angular-devkit/build-angular:browser' builder's node package.`	23:50:01
Lily Foster	I think this is something we could support in buildNpmPackage without much work. I can provide guidance if you want to add that (shouldn't need much besides adding a header to the fetcher code based on an env var and possibly adding it as a impure env var on the fetcher derivation)	23:51:50
Lily Foster	If you want me to get to it in the next week or two, open a github issue and ping me. It really shouldn't take long to implement :)	23:52:27
countoren	sure I could loom into it	23:53:39
countoren	look	23:53:43
countoren	what will be the correct way with buildNpmPackage to use ng?	23:54:22
countoren	straight buildInputs?	23:55:05
Lily Foster	`nativeBuildInputs`, but yeah probably. I never used angular/ng so I know nothing about it really	23:57:25
countoren	ok cool Ill check it out	23:59:06
9 Aug 2023
countoren	I guess if ill dive into the nixpkgs can again, I might add more nodePackages to ng if I am missing anything	00:01:49
countoren	did you guys ever got: ```bash pop_var_context: head of shell_variables not a function context	01:53:03
countoren	* did you guys ever got: `pop\_var\_context: head of shell\_variables not a function context`	01:53:24
countoren	when i am trying to run ng build in postInstall(node2nix)	01:54:26
countoren	* did you guys ever got: `> /nix/store/pgf87rgkzdbqhhsddpligy8xiwar63w8-stdenv-linux/setup: line 136: pop_var_context: head of shell_variables not a function context`	02:28:45
@gdesforges:matrix.org	Lily Foster: I've closed previous PR and pushed a new PR https://github.com/NixOS/nixpkgs/pull/248107	09:21:55
Lily Foster	In reply to @countoren:matrix.org did you guys ever got: `> /nix/store/pgf87rgkzdbqhhsddpligy8xiwar63w8-stdenv-linux/setup: line 136: pop_var_context: head of shell_variables not a function context` That's a harmless warning from bash. The build error should be above that	10:16:44
countoren	Lily Foster: I was trying to look around buildNpmPackage and fetchNpmDeps, what did you had in mind in order to setup the token?	14:21:54
countoren	* Lily Foster: I am looking at buildNpmPackage and fetchNpmDeps, what did you have in mind in order to setup the token?	14:22:20
countoren	is it NPM_TOKEN env that we need to set?	14:23:20
countoren	* Lily Foster: I am looking at buildNpmPackage and fetchNpmDeps, what do you have in mind in order to setup the token?	14:23:46
Lily Foster	In reply to @countoren:matrix.org is it NPM_TOKEN env that we need to set? Yeah and it'll need to be read here (and support for HTTP Authorization header added to the util function): https://github.com/NixOS/nixpkgs/blob/fe7a15579219350f23135e9e8ee35b7423ae06ef/pkgs/build-support/node/fetch-npm-deps/src/parse/mod.rs#L160	18:53:08
Lily Foster	I'll try to hack something up later today. If I implement, could I get you to test it?	18:53:37
Lily Foster	In reply to @lily:lily.flowers Yeah and it'll need to be read here (and support for HTTP Authorization header added to the util function): https://github.com/NixOS/nixpkgs/blob/fe7a15579219350f23135e9e8ee35b7423ae06ef/pkgs/build-support/node/fetch-npm-deps/src/parse/mod.rs#L160 And it should be added to the list of impure env vars here: https://github.com/NixOS/nixpkgs/blob/cd6d4800edca7c9765f40a4416569911d7952b30/pkgs/build-support/node/fetch-npm-deps/default.nix#L168	18:55:35
countoren	sure	19:26:10
countoren	I could test if you got something.	19:34:22
Lily Foster	In reply to @countoren:matrix.org I could test if you got something. Okay, thank you! I'll probably have something in ~3 hours or so	19:35:08
countoren	Lily Foster: do you know how can I manually add dependencies to a package built by buildNodePackage	20:07:49
countoren	was trying to override with more nativeBuildInputs but it does not seem to work	20:08:27

Show newer messages

Back to Room ListRoom Version: 6