| 30 Jul 2023 |
 dotlambda | turns out it's due to this line in package.json:
{
"devDependencies": {
"karma": "."
}
}
| 06:04:42 |
|  h7x4 joined the room. | 08:30:48 |
 Lily Foster | In reply to @robert:funklause.de
turns out it's due to this line in package.json:
{
"devDependencies": {
"karma": "."
}
}
Oh hmm, I can probably make that work if npm allows that, but does npm really allow using a package as a dev dependency of itself? | 10:50:19 |
 gdamjan | npm - everything goes | 10:50:55 |
| gdamjan | what's even the point of that | 10:51:12 |
| Lily Foster | In reply to @gdamjan:spodeli.org
what's even the point of that I think given it's a test runner that it's probably to allow them to run their own tests with itself | 10:53:22 |
| Lily Foster | But I imagine that would really only work when there are no lifecycle scripts that need to run to build the package (e.g. to run typescript compiler or something) | 10:54:27 |
| Lily Foster | (Still surprised it allows it at all though) | 10:54:40 |
| gdamjan | Lily Foster: executive decision time. stdenv.mkDerivation https://gist.github.com/gdamjan/08901abe49baadf083034e93ed32ccbe#file-default-2-nix
or try to hack around with mkYarnPackage and try to make https://gist.github.com/gdamjan/08901abe49baadf083034e93ed32ccbe#file-default-nix work ? | 12:23:33 |
| Lily Foster | In reply to @gdamjan:spodeli.org
Lily Foster: executive decision time. stdenv.mkDerivation https://gist.github.com/gdamjan/08901abe49baadf083034e93ed32ccbe#file-default-2-nix
or try to hack around with mkYarnPackage and try to make https://gist.github.com/gdamjan/08901abe49baadf083034e93ed32ccbe#file-default-nix work ? Why do you have to set the yarn config twice here? https://gist.github.com/gdamjan/08901abe49baadf083034e93ed32ccbe#file-default-2-nix-L71 | 12:25:08 |
| Lily Foster | Also if you can use fixup-yarn-lock from prefetch-yarn-deps rather than fixup_yarn_lock from yarn2nix https://github.com/NixOS/nixpkgs/issues/240174 | 12:26:06 |
| gdamjan | I don't know, but the yarn --production pruning tried to download without that (and failed because of the --ofline) | 12:26:11 |
| gdamjan | I'm guessing themktemp HOME was removed between the phases? | 12:27:01 |
| gdamjan | * I'm guessing the mktemp HOME was removed between the phases? | 12:27:08 |
| Lily Foster | In reply to @gdamjan:spodeli.org
I'm guessing the mktemp HOME was removed between the phases? Oh yeah it's because of this https://gist.github.com/gdamjan/08901abe49baadf083034e93ed32ccbe#file-default-2-nix-L58 | 12:27:27 |
| Lily Foster | Is that necessary? | 12:27:33 |
| gdamjan | In reply to @lily:lily.flowers
Is that necessary? I've seen it used in nixpkgs, but let's check | 12:28:04 |
| gdamjan | but afaik HOME is where yarn config stores the config, and without it, nix sets HOME to a non-existent directory, doesn't it? | 12:29:25 |
| Lily Foster | No i mean why set home twice? | 12:30:16 |
| Lily Foster | It should just be needed once | 12:30:20 |
| gdamjan | I thought it was a different shell instance | 12:31:18 |
| Lily Foster | No all phases are evaluated in the same bash instance in stdenv | 12:32:05 |
| gdamjan | let me see | 12:32:09 |
| Lily Foster | In reply to @lily:lily.flowers
No all phases are evaluated in the same bash instance in stdenv (Unless you call bash again in your phase I guess) | 12:32:36 |
| gdamjan | you're right. thanks. | 12:33:59 |
| gdamjan | https://github.com/NixOS/nixpkgs/compare/master...gdamjan:nixpkgs:bump-matrix-appservice-irc-2?expand=1
here's that in pre-PR form :D | 12:42:06 |
| Lily Foster | Sweet! I'll be able to take a look in like ~6 hours (feel free to remind me if I forget too....) | 12:43:15 |
| gdamjan | I'll open a PR for the mkDerivation if this is the better approach than mkYarnPackage | 12:44:53 |
| Lily Foster | I think it probably will be, but I'm also biased in that I want to kill yarn2nix 🙈 | 12:45:33 |
| gdamjan | :D | 12:46:18 |
