| 5 Jul 2023 |
Lily Foster | Oh really? I may be misremembering then. I try to think about yarn2nix as little as I can | 14:16:27 |
adamcstephens | i was looking at pnpm-lock-export yesterday to see if i could add the newer lock file format. so you're telling me we probably don't want to go pnpm->yarn :) | 14:17:44 |
adamcstephens | I'd like to help find a solution for pnpm before too long since woodpecker is using it | 14:25:02 |
Lily Foster | Well I hope to dump yarn2nix at some point. We're cooking up newer tooling for yarn but it'll be a bit | 14:30:08 |
adamcstephens | the quickest route for pnpm is probably to update the lock exporter, if i can wrap my head around what it's doing | 14:31:18 |
@ambroisie:belanyi.fr | In reply to @adam:valkor.net i was looking at pnpm-lock-export yesterday to see if i could add the newer lock file format. so you're telling me we probably don't want to go pnpm->yarn :) I think using yarn as a stopgap is good enough for our purposes | 19:08:52 |
@ambroisie:belanyi.fr | And thanks for looking into it ❤️ | 19:09:10 |
Lily Foster | In reply to @lily:lily.flowers Well I hope to dump yarn2nix at some point. We're cooking up newer tooling for yarn but it'll be a bit (We have that project board now for anyone who wants to see the rough priority/ordering for stuff. And of course help on any of the "todo" items is very appreciated) | 19:22:20 |
| 10 Jul 2023 |
Janne Heß | Lily Foster: my yarn thingie ended up working btw. It looks like the cache just builds reproducibly. Yarn versions can be fixed by doing yarn set version and copying .yarn into the cache FOD and then copying it to the sandbox in the real build | 10:05:12 |
Lily Foster | In reply to @janne.hess:helsinki-systems.de Lily Foster: my yarn thingie ended up working btw. It looks like the cache just builds reproducibly. Yarn versions can be fixed by doing yarn set version and copying .yarn into the cache FOD and then copying it to the sandbox in the real build Oh cool, can you try it across a few yarn versions? | 10:05:40 |
Lily Foster | (For reproducibility?) | 10:05:54 |
Janne Heß | Since people actually commit the version for me, I don't actually use yarn set version. I just noticed that since I need it at runtime so it has to be copied to $out as well | 10:06:58 |
Janne Heß | So the fact that .yarn has to be copied affects me between build and run, not between the FOD and the build | 10:07:26 |
Janne Heß | (Also kind of related, turborepo and next.js is possibly the worst garbage I have seen in a long time) | 10:07:54 |
| 13 Jul 2023 |
| aktaboot changed their profile picture. | 06:56:51 |
| 14 Jul 2023 |
Janne Heß | Umm, is this intended? https://github.com/NixOS/nixpkgs/blob/release-23.05/pkgs/build-support/node/build-npm-package/hooks/default.nix#L9 | 15:00:20 |
Janne Heß | This causes (buildNpmPackage.override { nodejs = nodejs_14; }) to fail horribly | 15:00:37 |
Lily Foster | Yes it's intended. Can you share build log? | 15:00:51 |
Lily Foster | Oh, 14 | 15:00:59 |
Lily Foster | Uhhh one sec while I check | 15:01:02 |
Lily Foster | That | 15:01:03 |
Janne Heß | Workaround that is even worse: (buildNpmPackage.override { nodejs = nodejs_14; npmHooks = npmHooks.override { buildPackages = buildPackages.extend (self: super: { nodejs = super.nodejs_14; }); }; }) | 15:01:07 |
Lily Foster | Oh I see what you're saying is unintended | 15:01:23 |
Janne Heß | In reply to @lily:lily.flowers Oh I see what you're saying is unintended Yeah sorry that was super unclear | 15:01:37 |
Lily Foster | We should probably just fish out the correct one from spliced attrs | 15:01:49 |
Lily Foster | I guess | 15:01:52 |
Janne Heß | or some extra arg like nodeVersion that gets fed into getAttrByPath pkgs? | 15:02:12 |
Janne Heß | * or some extra arg like nodePackage that gets fed into getAttrByPath pkgs? | 15:02:35 |
Lily Foster | I'd rather keep the ability to specify a whole nodejs derivation and also since you linked 23.05, we want something backwards compatible so it is eligible for backport | 15:02:39 |
Lily Foster | Ugh this sucks, though. Maybe we can have the nodejs derivation itself expose the node-gyp location | 15:04:24 |