Nix NodeJS | 211 Members | |
| 62 Servers |
| Sender | Message | Time |
|---|---|---|
| 4 Jul 2023 | ||
In reply to @janne.hess:helsinki-systems.deIs it sri or just bare sha512? | 08:49:12 | |
In reply to @lily:lily.flowers
| 08:49:21 | |
In reply to @lily:lily.flowersI will try. 5 lines of bash is probably a lot easier than having custom node code that parses 2 different lock files ;) | 08:49:41 | |
In reply to @janne.hess:helsinki-systems.deOh you mean for fetching. I'm not sure if lockfile fixup is still required for git deps for yarn berry or not. It was for yarn1 and so needed a custom fetcher | 08:50:41 | |
In reply to @lily:lily.flowersNo I mean for generating the hash for fetchYarnDeps | 08:51:14 | |
| If lockfile fixup is not needed and their cache format is reproducible, sure that could maybe work | 08:51:29 | |
In reply to @janne.hess:helsinki-systems.deAh both actually… | 08:51:53 | |
In reply to @janne.hess:helsinki-systems.deNo fetchYarnDeps is not the same cache format technically | 08:51:56 | |
| If you're trying to get something specific working, there is a yarn v2+ to yarn v1 lockfile rewriter in nixpkgs that some packages have used | 08:53:05 | |
In reply to @lily:lily.flowersThat's possible? 👀 | 08:53:19 | |
| I thought it was. I may be misremembering? (If it is though, it might be easier if yarn berry turns out to be a lot of trouble to create new tooling for atm) | 08:54:09 | |
| So good news: a yarn offline cache appears to be reproducible | 10:56:58 | |
| 10:57:05 | |
| (we will see if this also builds in a couple of months…) | 10:57:39 | |
In reply to @janne.hess:helsinki-systems.deWait this would still be yarn v1 right? We don't have yarn-berry in nixpkgs yet I thought | 11:02:39 | |
| (Oops meant to set that as a reply to the other message) | 11:02:55 | |
| * (Oops, meant to set that as a reply to the other message) | 11:03:03 | |
In reply to @lily:lily.flowersinteresting… still manages to parse the v2 lockfile | 11:49:39 | |
In reply to @lily:lily.flowers
| 13:37:00 | |
| 5 Jul 2023 | ||
| mkYarnPackage reads the package.json from src. This should work as expected right? in https://github.com/NixOS/nixpkgs/pull/241314 the submitter is saying they're receiving this error when trying to build without copying package.json into nixpkgs: https://gist.github.com/GrahamcOfBorg/77965b591af2aef7b6a5c40bb0d08391 | 13:45:33 | |
| when i remove it and build everything works correctly | 13:46:05 | |
| * when i remove it and build everything works correctly locally | 13:46:57 | |
In reply to @adam:valkor.netThat's IFD | 14:01:40 | |
| i see, so it's expected to copy the package.json into nixpkgs? | 14:02:16 | |
| With yarn2nix, yeah unfortunately | 14:09:53 | |
| You also need the yarn.lock and yarn.nix... it's, uh, unfortunate | 14:10:13 | |
In reply to @lily:lily.flowersso that PR should have both those files included a well? | 14:11:50 | |
I didn't look at the PR, but probably? Try to build with --no-import-from-derivation and see what it needs | 14:12:45 | |
| ok, yeah that reproduces the error | 14:15:08 | |
| yarn.lock isn't necessary it seems | 14:15:49 | |