| 9 Oct 2023 |
 Lily Foster | ohhhhh i know exactly what is happening now | 15:18:58 |
 Cobalt | okay, after a few reruns the error ratio is around 50% | 15:18:55 |
| Cobalt | Same error every time | 15:18:59 |
| Lily Foster | Ugh i hate this | 15:19:03 |
| Lily Foster | So retry is only done after http stuff is finished, but if a failure occurs while reading a large body, it bubbles back out since it's already left the code that does the retry | 15:20:00 |
| Lily Foster | * So retry is only done until http stuff is finished, but if a failure occurs while reading a large body, it bubbles back out since it's already left the code that does the retry | 15:20:09 |
| Lily Foster | I guess I'll just make it always read the full body into memory? | 15:20:32 |
| Lily Foster | Prior to exiting that code | 15:21:01 |
| Cobalt | Idk, I'm trying to grok the code at the moment. | 15:21:14 |
| Lily Foster | me too, and i wrote this part... | 15:24:35 |
| Cobalt | This error seems frustrating, when running the code outside of nix (run|build) it doesn't appear to be reproducible. Ig my network needs to become more unstable | 15:39:50 |
| Lily Foster | Okay I think we're fixed now! Try it again Cobalt, same branch | 15:42:26 |
| Lily Foster | In reply to @c0ba1t:matrix.org
This error seems frustrating, when running the code outside of nix (run|build) it doesn't appear to be reproducible. Ig my network needs to become more unstable Yeah no clue why it would be related to that. Except maybe namespacing shenanigans | 15:42:51 |
| Lily Foster | Oh you mean when built from nix, not when run in a nix build | 15:43:17 |
| Lily Foster | Yeah no clue there | 15:43:20 |
| Lily Foster | Except http/2 shenanigans since if you build it with static libcurl, then it'll build without libnghttp2 support | 15:43:39 |
| Lily Foster | But our libcurl does use it | 15:43:42 |
| Lily Foster | Either way it's not the core issue, just side effects | 15:43:50 |
| Cobalt | First run was successful, reruns may take a few minutes | 15:45:22 |
| Lily Foster | No worries! If you're able, feel free to rerun it as much as you can in loop and just come back to it when you can. I'm pretty sure I think I got it now | 15:45:46 |
| Lily Foster | I'm gonna open https://github.com/NixOS/nixpkgs/compare/master...lilyinstarlight:nixpkgs:fix/prefetch-npm-deps-network-error-recovery as a PR if a few people confirm it works | 15:46:02 |
| Lily Foster | Maybe Marie too | 15:46:06 |
| Cobalt | In reply to @lily:lily.flowers
No worries! If you're able, feel free to rerun it as much as you can in loop and just come back to it when you can. I'm pretty sure I think I got it now Sure, I'll try with 50 runs for now. The first 10 were successful, so it seems resolved. | 15:49:11 |
| Lily Foster | Also thiloho ^ | 15:49:15 |
| Lily Foster | * Also thiloho, if you could try ^ | 15:49:24 |
| Lily Foster | I've opened https://github.com/NixOS/nixpkgs/pull/260011 | 15:57:00 |
| Cobalt | In reply to @c0ba1t:matrix.org
Sure, I'll try with 50 runs for now. The first 10 were successful, so it seems resolved. All 50 runs were successful | 16:08:20 |
 Marie | In reply to @lily:lily.flowers
Maybe Marie too will do! | 16:08:39 |
| 10 Oct 2023 |
 Pol | Hey, I'm trying to package Terminalizer with buildNpmPackage. | 06:26:15 |
| Pol | { buildNpmPackage
, fetchFromGitHub
}:
buildNpmPackage rec {
pname = "terminalizer";
version = "0.11.0";
src = fetchFromGitHub {
owner = "faressoft";
repo = "terminalizer";
rev = "v${version}";
hash = "sha256-+62OM7pVtBRpeniO4e3X41R8nnk95Dk1EUL3HEEIZe4=";
};
npmDepsHash = "sha256-5em+VGNb+sbO7nPSvbo99fTi9O2RIUjBG2KvMRz6N6M=";
meta.mainProgram = "terminalizer";
}
| 06:26:24 |
