| 31 Jul 2023 |
Lily Foster | In reply to @robert:funklause.de Then I guess there are more important things to work on If you want to work on that, feel free to, but it'll be a while before we get there. We really should come up with at least some workarounds though for packaging lerna apps since they keep popping up (even though npm has native monorepo support with workspaces now which we do support since it didn't actually take that much extra effort) | 21:29:30 |
Lily Foster | (I'm not even sure what's the best way to handle lerna tbh. I've never used it and it's been rather annoying when toying with trying to build lerna repos with npm) | 21:30:58 |
Lily Foster | * (I'm not even sure what's the best way to handle lerna tbh. I've never used it and it's been rather annoying when toying with trying to build lerna repos with npm alone) | 21:31:07 |
Lily Foster | (if you really want though, you could use the npm registry tarball as src and then copy in a vendored lockfile in postPatch. But I really don't want to vendor any more lockfiles than we have to in nixpkgs.....) | 21:31:47 |
Lily Foster | (especially with how big npm ones get) | 21:32:04 |
gdamjan | In reply to @gdamjan:spodeli.org why didn't I see this though?! I did run the tests too 😱 | 21:54:04 |
| 1 Aug 2023 |
gdamjan | how exactly did you get this? just running the CLI doesn't error out for me | 07:59:03 |
hexa | so did I | 10:54:28 |
hexa | ofborg also ran them and they were green before merge | 10:54:40 |
gdamjan | what's the game plan now? add the package.json file back, and perhaps add strictDeps=true? | 11:11:09 |
hexa | yes | 11:38:38 |
gdamjan | https://github.com/NixOS/nixpkgs/pull/246554 | 11:58:57 |
dotlambda | Do we want to support npm-shrinkwrap.json in buildNpmPackage? | 16:01:49 |
Lily Foster | In reply to @robert:funklause.de Do we want to support npm-shrinkwrap.json in buildNpmPackage? If someone wants to write it. Right now it's not on our radar though | 16:03:53 |
dotlambda | In reply to @lily:lily.flowers If someone wants to write it. Right now it's not on our radar though Doesn't it have the exact same syntax? So it would just require checking which of the two files is present | 16:04:25 |
Lily Foster | Are you interested in adding more of this stuff? Do you want to join the nixpkgs node.js team? | 16:04:41 |
Lily Foster | In reply to @robert:funklause.de Doesn't it have the exact same syntax? So it would just require checking which of the two files is present Hmm yeah I think it might be. I'll have to double check | 16:04:57 |
dotlambda | In reply to @lily:lily.flowers Are you interested in adding more of this stuff? Do you want to join the nixpkgs node.js team? Not really, I don't actually know Node.js :D | 16:05:06 |
Lily Foster | In reply to @robert:funklause.de Not really, I don't actually know Node.js :D Hey, neither did I when I joined 🙃 | 16:06:28 |
Lily Foster | (I'm only partly joking in that too...) | 16:06:47 |
Lily Foster | (I'd used it but I was not familiar with a lot of npm behavior or cache or lock formats or anything) | 16:07:28 |
Lily Foster | (Apologies if offering was a bit too forward, I just want more people to collab with 😅) | 16:08:06 |
dotlambda | In reply to @lily:lily.flowers (Apologies if offering was a bit too forward, I just want more people to collab with 😅) No worries at all. Very understandable | 16:20:02 |
raitobezarius | In reply to @lily:lily.flowers (Apologies if offering was a bit too forward, I just want more people to collab with 😅) (I definitely think this is the right approach ; apologies I'm not sending PRs yet… It's very much on my todolist) | 16:22:37 |
Lily Foster | In reply to @raitobezarius:matrix.org (I definitely think this is the right approach ; apologies I'm not sending PRs yet… It's very much on my todolist) (It's okay, I always appreciate however much or little you're able to do ❤️) | 16:28:08 |
| 2 Aug 2023 |
dotlambda | In reply to @lily:lily.flowers Yeah I figured if they were using lerna you'd run into issues with intra-repo dependencies. Which lerna does custom handling for :/ I was thinking about trying to merge all lockfiles into one. Does someone know a tool for merging multiple JSON files into one with recursive merging and a specified file taking precedence in case of conflicts? | 06:00:15 |
Lily Foster | In reply to @robert:funklause.de I was thinking about trying to merge all lockfiles into one. Does someone know a tool for merging multiple JSON files into one with recursive merging and a specified file taking precedence in case of conflicts? jq | 10:26:46 |
dotlambda | In reply to @lily:lily.flowers
jq Nice, didn't know jq could do this | 14:49:15 |
Lily Foster | Jq can do anything, if you can manage to wrap your head around it's sometimes-painful expression language... | 15:17:21 |
Lily Foster | * Jq can do anything, if you can manage to wrap your head around its sometimes-painful expression language... | 15:17:28 |