| 2 Jun 2023 |
raitobezarius | Adding a simple permittedInsecurePackages in the meantime is not too shocking and we allowed caching exceptions for Node.js 16 and OpenSSL 1.1 to make the ride less bumpy for everyone | 13:38:47 |
Lily Foster | Yeah it's an upstream issue anyway. If your package needs 16, you can just enable insecure packages in nixpkgs 🤷♀️ | 13:39:02 |
adamcstephens | Yeah I figured we wouldn’t want to revert, just putting the question out there. | 13:39:46 |
Lily Foster | In reply to @raitobezarius:matrix.org We opened an issue on affected packages for Node.js 16 Oh really? Yeah how many are left? (Also were node maintainers pinged on that issue I don't remember seeing one other than the lists on the PR 🤔) | 13:40:04 |
raitobezarius | airfield, base16-builder, netlify-cli, spacegun, n8n? | 13:40:35 |
raitobezarius | are the remaining ones | 13:40:39 |
raitobezarius | wait I'm not uptodate on master | 13:40:54 |
Lily Foster | Okay that's not too bad. I thought netlify was already handled though | 13:40:58 |
Lily Foster | And spacegun has been broken well before the 16 deprecation iirc | 13:41:13 |
raitobezarius | apologies | 13:41:30 |
Lily Foster | In reply to @lily:lily.flowers Okay that's not too bad. I thought netlify was already handled though (Pretty sure I merged Robert's PR for that) | 13:41:36 |
raitobezarius | we only have netlify-cli left on master | 13:41:36 |
raitobezarius | then someone forgot to update the generate.sh | 13:41:50 |
Lily Foster | Oh maybe I'm misremembering then | 13:41:50 |
raitobezarius | for netlify-cli | 13:41:52 |
Lily Foster | Oh | 13:41:57 |
Lily Foster | rip | 13:41:59 |
raitobezarius | it will still generate with nodejs-16 for the next upgrade | 13:41:59 |
raitobezarius | but it's true that we don't have netlify cli with nodejs 16 anymore | 13:42:10 |
raitobezarius | so in fact | 13:42:11 |
raitobezarius | only codeserver shit is nodejs16 ? | 13:42:16 |
raitobezarius | this is definitely not worth a rollback | 13:42:21 |
Lily Foster | In reply to @raitobezarius:matrix.org it will still generate with nodejs-16 for the next upgrade I didn't notice that in the PR, oops 😅 | 13:42:25 |
raitobezarius | no worries! | 13:42:29 |
raitobezarius | we have the same thing for nodejs-16 actually on some packages | 13:42:39 |
raitobezarius | * we have the same thing for nodejs-14 actually on some packages | 13:42:42 |
Lily Foster | I just commented on the netlify PR | 13:44:45 |
@drupol:matrix.org | I though that would be a game changer, but... It's not. | 14:40:57 |
Lily Foster | In reply to @drupol:matrix.org I though that would be a game changer, but... It's not. Has upstream confirmed they intend to support 18+ soon? You can still use codeserver, it's just gonna be marked insecure. Hydra is even still building it | 14:49:19 |
@drupol:matrix.org | When a derivation requires an insecure dependency, is it also marked insecure ? | 14:50:31 |