25 Mar 2023 |
@ambroisie:belanyi.fr | No idea, I don't know the JS ecosystem funnily enough | 12:48:16 |
@ambroisie:belanyi.fr | My only experience is packaging some front-ends for nixpkgs :') | 12:48:29 |
Lily Foster | Wish I didn't know JS sometimes 🫠| 12:51:16 |
@ambroisie:belanyi.fr | Seems to be on npmjs.com | 12:51:58 |
Lily Foster | Yep it is. So use fetchzip and https://registry.npmjs.org/pnpm-lock-export/-/pnpm-lock-export-${version}.tgz | 12:52:35 |
Lily Foster | With buildNpmPackage | 12:52:45 |
Lily Foster | And you should be good | 12:52:51 |
@ambroisie:belanyi.fr | Thanks | 12:52:54 |
@ambroisie:belanyi.fr | Arf, no package-lock.json in the registry tarball | 13:00:09 |
@ambroisie:belanyi.fr | I'll have to create the lock myself | 13:03:07 |
Lily Foster | In reply to @ambroisie:belanyi.fr Arf, no package-lock.json in the registry tarball Wait really? I thought they always required that but maybe I'm misremembering | 13:04:51 |
Lily Foster | Wow it sure doesn't | 13:06:28 |
Lily Foster | Cursed | 13:06:30 |
@ambroisie:belanyi.fr | Like the rest of JS | 13:07:08 |
Lily Foster | I guess you could put it in the nodePackages set, which does locking entirely independent of tooling | 13:14:51 |
@ambroisie:belanyi.fr | I just wrote an update script which does npm install --lock-only and patch it in | 13:35:02 |
@ambroisie:belanyi.fr | I don't know which would be preferred when I'll be upstreaming this | 13:35:32 |
@ambroisie:belanyi.fr | For now I just need to see if it works for my purposes | 13:35:41 |
@ambroisie:belanyi.fr | What's the correct way to expose the executable when using buildNpmPackage ? | 13:37:56 |
@ambroisie:belanyi.fr | nix build .#pnpm-lock-export gives result/bin/@cvent/pnpm-lock-export | 13:38:38 |
Lily Foster | Wait really 💀 | 13:57:13 |
Lily Foster | That might be fixed by one of the pending PRs. I'll check later | 13:57:24 |
Lily Foster | I really need to get those cleaned up and merged | 13:57:36 |
@ambroisie:belanyi.fr | I think it's because the name field in package.json is @cvent/pnpm-lock-export | 13:59:06 |
@ambroisie:belanyi.fr | Yup, subsituteInPlace to remove the @cvent in name fixes it | 13:59:36 |
@ambroisie:belanyi.fr | Why did woodpecker decide to migrate from yarn anyway | 14:40:25 |
@ambroisie:belanyi.fr | Mmh I'm thinking my issue might be a tooling issue rather than a package fetch problem When trying to use both mkYarnPackage and buildNpmPackage I get the same issue about failing to find esbuild 🤔 | 19:32:41 |
Lily Foster | Oh.. esbuild... add it to nativeBuildInputs I guess? | 19:45:46 |
@ambroisie:belanyi.fr | It's not about trying to execute esbuild , it's earlier | 20:02:44 |
@ambroisie:belanyi.fr | I think I'll need to patch the package file to remove the need for esbuild | 20:03:15 |