15 Jul 2024 |
hexa | their release process only calls yarn build here https://github.com/music-assistant/frontend/blob/main/.github/workflows/release.yml#L65 | 11:02:35 |
hexa | Redacted or Malformed Event | 11:23:36 |
hexa | Redacted or Malformed Event | 11:23:58 |
hexa | https://github.com/music-assistant/frontend/blob/main/vite.config.ts#L19-L21 | 11:24:41 |
hexa | of course fonts are downloaded during build | 11:24:58 |
emily | it's from Google, when does anything they run ever disappear? :) | 11:26:23 |
hexa | I'm pretty sure we have a number of packages missing fonts due to this 😄 | 11:27:39 |
hexa | because it doesn't actually fail to build | 11:27:52 |
hexa | ✓ 781 modules transformed.
[webfont-dl] ✗ https://fonts.googleapis.com/css?family=Roboto:100,300,400,500,700,900&display=swap (try #1): getaddrinfo EAI_AGAIN fonts.googleapis.com
[webfont-dl] ✗ https://fonts.googleapis.com/css?family=Roboto:100,300,400,500,700,900&display=swap (try #2): getaddrinfo EAI_AGAIN fonts.googleapis.com
[webfont-dl] ✗ https://fonts.googleapis.com/css?family=Roboto:100,300,400,500,700,900&display=swap (try #3): getaddrinfo EAI_AGAIN fonts.googleapis.com
[webfont-dl] getaddrinfo EAI_AGAIN fonts.googleapis.com
| 11:29:39 |
emily | build-time font download module that doesn't bubble up errors | 11:32:12 |
emily | we just reached peak javascript | 11:32:16 |
hexa | and I mean, those are over 40 files | 11:33:19 |
hexa | I'm not going to fetchurl them | 11:33:22 |
hexa | this looks like a dead end for the source build to me | 11:34:23 |
emily | can't you just shim in our roboto package? | 11:36:25 |
hexa | those are truetype fonts, no? | 11:36:54 |
hexa | https://fonts.googleapis.com/css?family=Roboto:100,300,400,500,700,900&display=swap | 11:37:09 |
hexa | check the file, it wants web open font format | 11:37:27 |
hexa | * check the file, it wants WOFF2 instead | 11:37:37 |
emily | ah, true | 11:37:52 |
emily | we could build woff2s :') | 11:37:58 |
emily | they're just compressed ttfs after all! | 11:38:06 |
hexa | that sounds like lots of fun | 11:39:08 |
hexa | given that our current roboto build is this | 11:39:28 |
hexa | Download image.png | 11:39:29 |
emily | don't show me that, I'll replace it with something really slow and everyone will get mad | 11:40:01 |
Cobalt | Maybe it's worth to request upstream to just use font's from npm? Most stuff from Google font's and in particular Roboto is available in an npm package. | 11:40:51 |
Cobalt | * Maybe it's worth to request upstream to just use fonts from npm? Most stuff from Google font's and in particular Roboto is available in an npm package. | 11:41:02 |
hexa | In reply to @emilazy:matrix.org don't show me that, I'll replace it with something really slow and everyone will get mad that is precisely the issue with fonts, reminds me of #staging:nixos.org a while ago 😄 | 11:43:24 |
hexa | In reply to @c0ba1t:matrix.org Maybe it's worth to request upstream to just use fonts from npm? Most stuff from Google font's and in particular Roboto is available in an npm package. maybe, but that requires a relationship, given that I don't know what I'm talking about 🙂 | 11:43:53 |