Sender | Message | Time |
---|---|---|
29 Apr 2024 | ||
matejam |
| 22:34:36 |
matejam | *
Yeah, sadly that seems to be the case... After adding | 22:35:02 |
30 Apr 2024 | ||
@dominic_:matrix.org left the room. | 20:07:37 | |
matejam | So, I made a new derivation that tries to mix buildComposerProject with fetchNpmDeps and npmHooks. Here's the link: https://github.com/MatejaMaric/yota-laravel/blob/7c2879793e752efbb92a1a419e77a64cffaf1a59/derivation.nix It returns the error /nix/store/2wd77cc3g2r9iqb7iwlgd881zvh6f576-npm-config-hook/nix-support/setup-hook: line 84: npm: command not found . | 20:31:18 |
Lily Foster | In reply to @matejam:matrix.orgyou need nodejs in nativeBuildInputs | 20:31:43 |
Lily Foster | you may also optionally need nodejs.python in nativeBuildInputs and nodejs in buildInputs if it has c++ libs | 20:32:43 |
Lily Foster | and ++ lib.optionals stdenv.isDarwin [ darwin.cctools ] on nativeBuildInputs if it has c++ libs too, for darwin | 20:33:06 |
matejam | I saw that fetchNpmDeps is able to automatically use nodejs_18. Should I also just specify nodejs_18 or is there some mechanism to automatically determine the version? | 20:34:04 |
Lily Foster | do you need nodejs_18? | 20:34:49 |
Lily Foster | (fetcher shouldn't actually even need nodejs at all 🤔) | 20:35:16 |
matejam | Maybe I'm wrong about nodejs_18, but I'm quite sure I saw it in the logs at some point. Anyway, in my previous fixed-point derivation I had to update my package-lock.json and with fetchNpmDeps I didn't have to do that which I really like 😄 | 20:37:20 |
matejam | I think that project used nodejs_16 but I'm okay with changing the version | 20:38:15 |
Lily Foster | i mean you can just use the nodejs attr which should always be latest LTS | 20:44:07 |
Lily Foster | unless it has C++ code in which case, nodejs breaks that a little between versions and you may want to pin one | 20:44:28 |
Lily Foster | (fwiw current LTS is nodejs_22 as of a few days ago) | 20:45:20 |
Lily Foster | (apparently) | 20:45:26 |
matejam | Here's a working version: https://github.com/MatejaMaric/yota-laravel/blob/c114ebc3c725a67a19d148a95543ed307094c659/derivation.nix Thanks a lot Lily! 🤗 | 20:45:42 |
Lily Foster | oh heck yeah, that's awesome :) | 20:45:58 |
matejam |
Yeah, I'll pin it. I had to add | 20:46:28 |
Lily Foster | In reply to @matejam:matrix.org(if you want, you can set npmBuildScript = "prod" and include npmBuildHook as well) | 20:46:36 |
Lily Foster | In reply to @matejam:matrix.org* (if you want, you can set npmBuildScript = "prod" and include npmBuildHook as well and remove the postBuild ) | 20:46:41 |
Cobalt | Iirc, the nodejs 22 LTS has some problems with node gyp. You might want to stick with 18 for a few more weeks until testing has been done | 20:46:49 |
Lily Foster | In reply to @c0ba1t:matrix.orgwell if they're using npmHooks and nodejs , it'll be 20 for a bit | 20:47:13 |
Lily Foster | i don't think nixpkgs has set nodejs = nodejs_22 yet (just node_20 ) | 20:47:27 |
Lily Foster | In reply to @c0ba1t:matrix.org(also what problems? that's concerning if their build tool didn't work on release....) | 20:47:44 |
Lily Foster | ( | 20:47:54 |
matejam |
Hm, for some reason if I do that it doesn't generate files that | 20:56:46 |
Cobalt | Iirc, it is on 22 on unstable. I don't remember the specifics but an unstable bum recently made our builds fail until we returned to 18. Iirc, it was similar to https://github.com/nodejs/node-gyp/issues/3029 | 20:59:57 |
Lily Foster | In reply to @matejam:matrix.orgshare derivation? (e.g. on a pastebin?) that seems weird | 21:00:53 |
Lily Foster | oh you know what | 21:01:00 |