2 Sep 2024 |
Winter | but you can also try just setting whatever that one environment variable is to get electron to pull locally, grep around nixpkgs for it | 15:15:06 |
aktaboot | In reply to @winter:catgirl.cloud but you can also try just setting whatever that one environment variable is to get electron to pull locally, grep around nixpkgs for it this ? ELECTRON_SKIP_BINARY_DOWNLOAD | 15:57:13 |
aktaboot | In reply to @winter:catgirl.cloud you'll need to give a lot more info than that I think I'll end up either opening a draft PR or on discourse 👀 | 15:58:06 |
Winter | In reply to @aktaboot:tchncs.de this ? ELECTRON_SKIP_BINARY_DOWNLOAD yeah | 15:59:02 |
3 Sep 2024 |
cafkafk | not sure if people have seen this, but just to make sure someone is aware, node 22.7.0 has a regression that breaks UTF-8 encoding. https://github.com/nodejs/node/issues/54543
Should probably skip that version | 02:42:05 |
cafkafk | (this breaks some databases) | 02:42:17 |
Winter | In reply to @cafkafk:gitter.im not sure if people have seen this, but just to make sure someone is aware, node 22.7.0 has a regression that breaks UTF-8 encoding. https://github.com/nodejs/node/issues/54543
Should probably skip that version awesome | 02:44:02 |
cafkafk | :)))))) | 02:44:30 |
emily | already in the current staging-next , maybe we should roll it back though | 02:48:04 |
Winter | i'd OK that | 02:48:24 |
Winter | make a PR pls | 02:48:29 |
Winter | * | 02:48:51 |
emily | I left https://github.com/NixOS/nixpkgs/pull/336556#issuecomment-2325514159 | 02:51:41 |
emily | it may be better to roll-forward and just apply https://github.com/nodejs/node/pull/54565/files | 02:51:54 |
emily | since the patch is very simple. | 02:51:57 |
emily | I will PR whatever people think is best. | 02:52:08 |
cafkafk | I prefer rolling back but it's not a very strong opinion (22.6 known to be ok vs 22.7+patch may be problematic in ways we dunno?) | 03:12:35 |
emily | soon it will be 22.8, so we will deal with the breakage either way | 03:13:36 |
emily | so I lean slightly towards rolling forward | 03:14:00 |
emily | https://github.com/nodejs/node/pull/54560#issuecomment-2324774721 | 03:14:13 |
emily | ok, 22.8 is literally releasing within ~a day | 03:14:21 |
emily | so let's not bother doing anything | 03:14:29 |
emily | will take much longer than that for staging-next to hit master anyway | 03:15:02 |
cafkafk | will 22.7 get through staging-next in that tim- | 03:15:09 |
cafkafk | aight :p | 03:15:14 |
Winter | sgtm, thanks emily | 03:18:13 |
emily | I subscribed to the releases on GitHub so I'll PR it when it happens. | 03:18:47 |
emily | to staging-next since the version in there now is known-broken | 03:18:56 |
4 Sep 2024 |
| SomeoneSerge (utc+3) changed their display name from SomeoneSerge (UTC+3) to SomeoneSerge (nix.camp). | 21:49:14 |
7 Sep 2024 |
aktaboot | hey, are there ongoing discussions on improving the status quo of nodejs&friends in nixpkgs ? | 11:13:27 |