| 4 Dec 2024 |
 dish [Fox/It/She] | I also looked through the dropped packages which is why a lot of the deprecated ones in the "potential drop" list have pending PRs | 00:53:41 |
| dish [Fox/It/She] | yup 💜 | 00:53:45 |
| dish [Fox/It/She] | should I link the PRs in the cards? or remove the cards and add my PRs as new items? | 00:54:36 |
| dish [Fox/It/She] | not sure how the workflow there should work | 00:54:43 |
| dish [Fox/It/She] | * not sure how the workflow there should go | 00:54:45 |
| dish [Fox/It/She] | * should I link the PRs in the cards? or remove the cards and add my PRs as new items in the project? | 00:55:38 |
 Tomodachi94 (they/them) | In reply to@pyrox:pyrox.dev
I also looked through the dropped packages which is why a lot of the deprecated ones in the "potential drop" list have pending PRs I'll take a look at the PRs tonight or tomorrow and review them; feel free to bug me if I forget | 00:56:15 |
| Tomodachi94 (they/them) | In reply to@pyrox:pyrox.dev
not sure how the workflow there should go I'm not sure either | 00:56:48 |
| dish [Fox/It/She] | alright, I was reminded that I should add release notes for the dropped ones, so I know I need to add those, but anything else of note would be appreciated. | 00:57:00 |
| Tomodachi94 (they/them) | In reply to@pyrox:pyrox.dev
should I link the PRs in the cards? or remove the cards and add my PRs as new items in the project? I've been deleting the cards, adding the PR, then reapplying the same tags, but I don't know if there's a better way | 00:57:30 |
| dish [Fox/It/She] | yeah that's what I figured I'd do | 00:57:49 |
| dish [Fox/It/She] | I'll update the existing cards in pending to be the PRs instead | 00:57:59 |
| dish [Fox/It/She] | also for completion's sake of what I've been doing, I've added a separate label for yarn-berry packages(non- yarn.lock v1) because those need different fetchDeps tooling than what's in nixpkgs currently, and so can't be packaged cleanly. anything yarn v1 should work well though. | 01:11:23 |
| dish [Fox/It/She] | I think that anything that's a library shouldn't be kept during the nodePackages removal. They're brought in by package managers, and nix shouldn't need to manage them. So I think dropping the tailwindcss plugins and others would be reasonable, as they aren't very easy to consume | 04:59:54 |
| dish [Fox/It/She] | any thoughts? | 05:04:31 |
| Tomodachi94 (they/them) | In reply to@pyrox:pyrox.dev
I think that anything that's a library shouldn't be kept during the nodePackages removal. They're brought in by package managers, and nix shouldn't need to manage them. So I think dropping the tailwindcss plugins and others would be reasonable, as they aren't very easy to consume I remember some sort of discussion or guideline that roughly states this | 06:35:11 |
| dish [Fox/It/She] | In reply to @tomodachi94:matrix.org
I remember some sort of discussion or guideline that roughly states this i figured there was, I just figured I'd let folks here know before I just drop a bunch more packages | 06:36:34 |
| dish [Fox/It/She] | also I really can't decide what do fo with all of sindresorhus' packages, he doesn't put lockfiles in any of them and I'm really hesitant to vendor a bunch of lockfiles in nixpkgs(what with bundle size concerns and all, one of the reasons I'm trying to help trim nodePackages) | 06:37:53 |
| dish [Fox/It/She] | so we need to find some way to store lockfiles where we can pull them and not hit ifd that's also outside of nixpkgs | 06:38:27 |
|  @wst:imagisphe.re left the room. | 15:21:12 |
| Tomodachi94 (they/them) | In reply to@pyrox:pyrox.dev
also I really can't decide what do fo with all of sindresorhus' packages, he doesn't put lockfiles in any of them and I'm really hesitant to vendor a bunch of lockfiles in nixpkgs(what with bundle size concerns and all, one of the reasons I'm trying to help trim nodePackages) Yeah that annoyed me too, there's one of his packages that I especially care about and would repackage if not for the missing lockfile | 15:45:29 |
| Tomodachi94 (they/them) | In reply to@pyrox:pyrox.dev
so we need to find some way to store lockfiles where we can pull them and not hit ifd that's also outside of nixpkgs Or convince him to include lockfiles 🙃 | 15:50:01 |
| dish [Fox/It/She] | In reply to @tomodachi94:matrix.org
Or convince him to include lockfiles 🙃 prob won't happen cuz so many packages of his haven't been touched in years 🥴 | 16:07:36 |
| dish [Fox/It/She] | ugh the tailwind libraries are used by a single thing in-tree(emanote) and idk what to do to fix them 🙃 | 20:35:01 |
| 5 Dec 2024 |
|  Toma joined the room. | 18:43:49 |
| Toma | Anyone know how one can fix the missing symbol errors for electron-based applications?
One of the .node files can't find a symbol: undefined symbol: _ZN2v89Exception9TypeErrorENS_5LocalINS_6StringEEE
Looks like the bin/node executable has that symbol, but the libexec/electron executable only has a different, but similar symbol:
_ZN2v89Exception9TypeErrorENS_5LocalINS_6StringEEENS1_INS_5ValueEEE
How can these ABI difference issues be resolved?
| 19:25:26 |
| Toma | Okay, I just probably have to useelectron-rebuild properly. Will experiment a bit | 20:22:51 |
| 6 Dec 2024 |
| Tomodachi94 (they/them) | @dish [Fox/It/She] I started a nixpkgs-review run for all of your nodePackages PRs (and the msrestazure ones). I'll be away for about two hours but it should automatically comment on the PRs as the builds finish | 02:54:06 |
| Tomodachi94 (they/them) | @dish [Fox/It/She] I started a nixpkgs-review run for all of your nodePackages PRs (and the msrestazure ones). I'll be away for about two hours but it should automatically comment on the PRs as the builds finish. I'll take a peek probably later tonight or perhaps tomorrow | 02:54:49 |
| Tomodachi94 (they/them) | @dish [Fox/It/She] I started a nixpkgs-review run for all of your nodePackages PRs (and the msrestazure ones). I'll be away for about two hours but it should automatically comment on the PRs as the builds finish. I'll take a peek probably later tonight or perhaps tomorrow, if time allows | 06:03:33 |
