28 Nov 2024 |
ghpzin | @Pol : Tried and commented. Surprisingly previous version 0.4.4 from nixos-unstable builds fine either way, so upstream probably added something between those versions that is heavy enough to trip over memory limits. | 17:20:30 |
@drupol:matrix.org | Thank you :) | 17:21:20 |
@drupol:matrix.org | Merging this now | 17:21:26 |
29 Nov 2024 |
| bl1nk changed their profile picture. | 01:11:44 |
| bl1nk changed their profile picture. | 01:12:00 |
| lassulus changed their profile picture. | 18:30:07 |
2 Dec 2024 |
| dish [Fox/It/She] changed their profile picture. | 19:59:08 |
3 Dec 2024 |
dish [Fox/It/She] | trying to package something that needs me to patch its yarn.lock. How can I pass that change through to fetchYarnDeps so that the dependencies fetch properly? | 19:33:15 |
dish [Fox/It/She] | I've tried making a patch and passing in patches , as well as a custom postPatch , and neither worked | 19:34:10 |
dish [Fox/It/She] | also, I'm going to make a PR dropping the nodePackages.webpack package, as nothing in-tree uses it, and if you're making a node package, it should be pulled from your lockfile via your package manager anyways. webpack-dev-server and webpack-cli are fine to keep, though. | 23:48:29 |
dish [Fox/It/She] | also, I'm going to make a PR dropping the nodePackages.webpack package, as nothing in-tree uses it, and if you're making a node package, it should be pulled from your lockfile via your package manager anyways. webpack-dev-server and webpack-cli are fine to keep, though, so I'm writing those packages to build with nixpkgs tooling | 23:48:40 |
4 Dec 2024 |
Tomodachi94 (they/them) | (Not sure if you found it already, but there's a list of packages needing repackaging here: https://github.com/orgs/NixOS/projects/83) | 00:50:45 |
dish [Fox/It/She] | yeah, I've been working through that | 00:52:58 |
Tomodachi94 (they/them) | Most of them are low-hanging fruit that just need a maintainer who wants to commit to maintaining it for at least two release cycles. Some could stand to be dropped (there's a view at https://github.com/orgs/NixOS/projects/83/views/9 where I flagged some packages in the same list; use your judgment and double-check everything before you drop it) | 00:53:05 |
dish [Fox/It/She] | if you see the pending PRs list(pyrox0 is my github username) | 00:53:07 |
Tomodachi94 (they/them) | Ah that's you 💖 | 00:53:24 |
dish [Fox/It/She] | I also looked through the dropped packages which is why a lot of the deprecated ones in the "potential drop" list have pending PRs | 00:53:41 |
dish [Fox/It/She] | yup 💜 | 00:53:45 |
dish [Fox/It/She] | should I link the PRs in the cards? or remove the cards and add my PRs as new items? | 00:54:36 |
dish [Fox/It/She] | not sure how the workflow there should work | 00:54:43 |
dish [Fox/It/She] | * not sure how the workflow there should go | 00:54:45 |
dish [Fox/It/She] | * should I link the PRs in the cards? or remove the cards and add my PRs as new items in the project? | 00:55:38 |
Tomodachi94 (they/them) | In reply to@pyrox:pyrox.dev I also looked through the dropped packages which is why a lot of the deprecated ones in the "potential drop" list have pending PRs I'll take a look at the PRs tonight or tomorrow and review them; feel free to bug me if I forget | 00:56:15 |
Tomodachi94 (they/them) | In reply to@pyrox:pyrox.dev not sure how the workflow there should go I'm not sure either | 00:56:48 |
dish [Fox/It/She] | alright, I was reminded that I should add release notes for the dropped ones, so I know I need to add those, but anything else of note would be appreciated. | 00:57:00 |
Tomodachi94 (they/them) | In reply to@pyrox:pyrox.dev should I link the PRs in the cards? or remove the cards and add my PRs as new items in the project? I've been deleting the cards, adding the PR, then reapplying the same tags, but I don't know if there's a better way | 00:57:30 |
dish [Fox/It/She] | yeah that's what I figured I'd do | 00:57:49 |
dish [Fox/It/She] | I'll update the existing cards in pending to be the PRs instead | 00:57:59 |
dish [Fox/It/She] | also for completion's sake of what I've been doing, I've added a separate label for yarn-berry packages(non- yarn.lock v1) because those need different fetchDeps tooling than what's in nixpkgs currently, and so can't be packaged cleanly. anything yarn v1 should work well though. | 01:11:23 |
dish [Fox/It/She] | I think that anything that's a library shouldn't be kept during the nodePackages removal. They're brought in by package managers, and nix shouldn't need to manage them. So I think dropping the tailwindcss plugins and others would be reasonable, as they aren't very easy to consume | 04:59:54 |