| 31 Oct 2024 |
 pxc | * I thought it was the other way around. --legacy-peer-deps doesn't have any real documentation the npm install docs afaict, which is annoying
at any rate, removing it made no difference :(
| 20:54:55 |
| pxc | I'll try also adding --no-optional, I suppose | 20:55:32 |
| pxc | nope, esbuild is made about --no-optional. I guess if you use esbuild, optionalDependencies are actually required 🙃 | 20:58:07 |
| pxc | * nope, esbuild is mad about --no-optional. I guess if you use esbuild, optionalDependencies are actually required 🙃 | 20:58:14 |
 Lily Foster | In reply to @pxc:matrix.org
nope, esbuild is made about --no-optional. I guess if you use esbuild, optionalDependencies are actually required 🙃 you can trivially get around that but also the problem here isn't optionalDependencies, but optional peerDependencies which are different | 21:01:29 |
| Lily Foster | * you can trivially get around that (search elsewhere in nixpkgs for prior art on esbuild insanity) but also the problem here isn't optionalDependencies, but optional peerDependencies which are different | 21:02:25 |
| pxc | well I have low confidence in the correctness but I did get a build that ran! since you pointed me at the npmFlags related to peer dependencies, I skimmed the NodeJS docs and decided to try --omit peer in place of --legacy-peer-deps, and the build succeeded
the tool does run from that build and at least some commands work
| 21:15:29 |
| Lily Foster | i mean if it runs and there's no obvious issues it's probably fine | 21:18:15 |
| Lily Foster | i forget if there is a knob to more directly exclude only optional peer deps and am on mobile or i'd just check the tool/code | 21:18:55 |
| pxc | I'll switch to it on this machine (currently using the one from MacPorts) and test it for like a day then submit a PR | 21:19:03 |
| pxc | tyvvm for your help! | 21:23:00 |
| 1 Nov 2024 |
 @gdesforges:matrix.org | Is there a way to add a package to nodePackages without updating the entire set?
I'm following https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/javascript.section.md#adding-and-updating-javascript-packages-in-nixpkgs-javascript-adding-or-updating-packages
But when I run ./pkgs/development/node-packages/generate.sh it starts a super long script that I guess updates pkgs/development/node-packages/node-packages.nix in its entirety.
Is there some incremental update that I'm unaware of?
Context: https://github.com/NixOS/nixpkgs/issues/351203 | 17:30:18 |
 Winter | use buildNpmPackage | 17:38:55 |
| Winter | don't use nodePackages anymore | 17:39:16 |
| @gdesforges:matrix.org | dang it! I just did it 😅 | 17:51:29 |
| @gdesforges:matrix.org | * dang it! I just did it and created the PR 😅 | 17:51:45 |
| Lily Foster | yeah nodePackages is very dead | 17:52:22 |
| Lily Foster | though admittedly no one ever updated the docs before i left nixpkgs | 17:52:59 |
| @gdesforges:matrix.org | so I switched it to buildNpmPackage, but it gets stuck after script patching
https://github.com/GuillaumeDesforges/nixpkgs/blob/8109150e8d773b115fcdb0ca5d9c2924c59cc9ca/pkgs/tools/typesetting/marp/default.nix
patching script interpreter paths in node_modules
node_modules/chrome-launcher/bin/print-chrome-path.js: interpreter directive changed from "#!/usr/bin/env node" to "/nix/store/jz54v1m0ldqivx5i45q8i05pz5clf842-nodejs-20.18.0/bin/node"
... many others, then it's stuck
and if I kill the nix-build the derivation becomes locked
| 21:16:19 |
| Winter | it's almost definitely not stuck | 21:16:55 |
| Winter | how long were you waiting | 21:17:06 |
| @gdesforges:matrix.org | 15 minutes | 21:17:16 |
| @gdesforges:matrix.org | I've known some binary patching taking long, but this was weird | 21:18:09 |
| @gdesforges:matrix.org | * I've known some binary patching taking long, but this looks weird | 21:18:25 |
| @gdesforges:matrix.org | * I've known some binary patching taking long, but this looks weird for a npm package | 21:18:34 |
| @gdesforges:matrix.org changed their profile picture. | 21:19:16 |
| Winter | can i get the full logs? | 21:20:50 |
| @gdesforges:matrix.org | sure | 22:46:11 |
| @gdesforges:matrix.org | mmmh so I rebooted and launched the build and it went beyond that point, unlike the two previous times. Might be a Nix bug? | 22:54:37 |
| Winter | unlikely | 22:56:45 |
