Sender | Message | Time |
---|---|---|
31 Oct 2024 | ||
In reply to @pxc:matrix.orgi did actually make a shellHook for buildNpmPackage packages to make that sort of check work, but i'm not contributing to nixpkgs anymore so oh well i guess | 20:29:51 | |
that sucks, but I understand | 20:30:32 | |
it looks like utf-8-validate appears multiple times in the dependency tree, and at least once as just a first-order dependency (and not a devDependency ). Are you sure they're all eliminable | 20:31:31 | |
i'd give snippet for disabling optional peer deps in npmInstallFlags or whatever it is, but i'm on mobile rn sadly | 20:31:33 | |
ty! | 20:31:43 | |
In reply to @pxc:matrix.orgall of the old ones that still try to build fat executables are from optional peer deps from microsoft etc pinning an ancient version of ws for some godawful reason | 20:33:01 | |
so they don't have to be all eliminable | 20:33:23 | |
got it | 20:33:32 | |
In reply to @lily:lily.flowers this was enough for me to find the flag and plenty of examples in Nixpkgs, if the flag was but this package already used that, and unlike the version I had building as part of | 20:47:37 | |
In reply to @lily:lily.flowers* this was enough for me to find the flag and plenty of examples in Nixpkgs, if the flag was but this package already used that, and unlike the version I had building as part of | 20:47:57 | |
In reply to @pxc:matrix.orgoh then take that out. i was wondering why it would be including peer deps at all without that flag | 20:48:27 | |
legacy-peer-deps does the opposite of what i suggested | 20:48:44 | |
by overeagerly including them | 20:48:55 | |
I thought it was the other way around at any rate, removing it made no difference :( | 20:53:33 | |
* I thought it was the other way around. at any rate, removing it made no difference :( | 20:54:55 | |
I'll try also adding --no-optional , I suppose | 20:55:32 | |
nope, esbuild is made about --no-optional . I guess if you use esbuild , optionalDependencies are actually required 🙃 | 20:58:07 | |
* nope, esbuild is mad about --no-optional . I guess if you use esbuild , optionalDependencies are actually required 🙃 | 20:58:14 | |
In reply to @pxc:matrix.orgyou can trivially get around that but also the problem here isn't optionalDependencies, but optional peerDependencies which are different | 21:01:29 | |
* you can trivially get around that (search elsewhere in nixpkgs for prior art on esbuild insanity) but also the problem here isn't optionalDependencies, but optional peerDependencies which are different | 21:02:25 | |
well I have low confidence in the correctness but I did get a build that ran! since you pointed me at the the tool does run from that build and at least some commands work | 21:15:29 | |
i mean if it runs and there's no obvious issues it's probably fine | 21:18:15 | |
i forget if there is a knob to more directly exclude only optional peer deps and am on mobile or i'd just check the tool/code | 21:18:55 | |
I'll switch to it on this machine (currently using the one from MacPorts) and test it for like a day then submit a PR | 21:19:03 | |
tyvvm for your help! | 21:23:00 | |
1 Nov 2024 | ||
Is there a way to add a package to nodePackages without updating the entire set? I'm following https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/javascript.section.md#adding-and-updating-javascript-packages-in-nixpkgs-javascript-adding-or-updating-packages But when I run ./pkgs/development/node-packages/generate.sh it starts a super long script that I guess updates pkgs/development/node-packages/node-packages.nix in its entirety.Is there some incremental update that I'm unaware of? Context: https://github.com/NixOS/nixpkgs/issues/351203 | 17:30:18 | |
use buildNpmPackage | 17:38:55 | |
don't use nodePackages anymore | 17:39:16 | |
dang it! I just did it 😅 | 17:51:29 | |
* dang it! I just did it and created the PR 😅 | 17:51:45 |