Nix NodeJS - Public Room Timeline

	Nix NodeJS	199 Members
		60 Servers

Load older messages

Sender	Message	Time
31 Oct 2024
pxc	here's the old version: https://pastebin.com/XDxvjsgs	20:18:36
pxc	yeah	20:18:37
emily	10.7 deployment target, nice	20:18:53
pxc	yeah the logs emitted a warning about that but I have no intuitions about whether it's meaningful	20:19:21
emily	shouldn't matter	20:19:54
pxc	current questions: Would it maybe be worthwhile to try building things further down the dependency tree as their own packages, also with `buildNpmPackage`, just to make it more convenient to see if tweaking their sources (maybe playing with `binding.gyp` helps)? If I do figure out something that works, how can I override transitive dependencies that have native deps like that?	20:22:58
pxc	build still fails on master because of missing `perl`, I'm a dingus. Lemme pull master into my local checkout with that fix instead	20:23:53
pxc	yeah, Darwin SDK changes on master don't seem to affect it	20:28:02
Lily Foster	In reply to @pxc:matrix.org current questions: Would it maybe be worthwhile to try building things further down the dependency tree as their own packages, also with `buildNpmPackage`, just to make it more convenient to see if tweaking their sources (maybe playing with `binding.gyp` helps)? If I do figure out something that works, how can I override transitive dependencies that have native deps like that? no you can technically intervene if you're crafty, but also it's an optional dep anyway so you can probably just turn those off	20:28:12
Lily Foster	In reply to @pxc:matrix.org `utf-8-validate` is a dependency of `@wessberg/ts-evaluator` as well but I don't see it in my `node_modules` when debugging with `nix-shell` i did actually make a shellHook for buildNpmPackage packages to make that sort of check work, but i'm not contributing to nixpkgs anymore so oh well i guess	20:29:51
pxc	that sucks, but I understand	20:30:32
pxc	it looks like utf-8-validate appears multiple times in the dependency tree, and at least once as just a first-order dependency (and not a `devDependency`). Are you sure they're all eliminable	20:31:31
Lily Foster	i'd give snippet for disabling optional peer deps in npmInstallFlags or whatever it is, but i'm on mobile rn sadly	20:31:33
pxc	ty!	20:31:43
Lily Foster	In reply to @pxc:matrix.org it looks like utf-8-validate appears multiple times in the dependency tree, and at least once as just a first-order dependency (and not a `devDependency`). Are you sure they're all eliminable all of the old ones that still try to build fat executables are from optional peer deps from microsoft etc pinning an ancient version of ws for some godawful reason	20:33:01
Lily Foster	so they don't have to be all eliminable	20:33:23
pxc	got it	20:33:32
pxc	In reply to @lily:lily.flowers i'd give snippet for disabling optional peer deps in npmInstallFlags or whatever it is, but i'm on mobile rn sadly this was enough for me to find the flag and plenty of examples in Nixpkgs, if the flag was `--legacy-peer-deps` but this package already used that, and unlike the version I had building as part of `nodePackages`, even the newer version still fails to build with that same message	20:47:37
pxc	In reply to @lily:lily.flowers i'd give snippet for disabling optional peer deps in npmInstallFlags or whatever it is, but i'm on mobile rn sadly * this was enough for me to find the flag and plenty of examples in Nixpkgs, if the flag was `--legacy-peer-deps` but this package already used that, and unlike the version I had building as part of `nodePackages`, even the newer version pulled in directly by `bitwarden-cli` still fails to build with that same message	20:47:57
Lily Foster	In reply to @pxc:matrix.org this was enough for me to find the flag and plenty of examples in Nixpkgs, if the flag was `--legacy-peer-deps` but this package already used that, and unlike the version I had building as part of `nodePackages`, even the newer version still fails to build with that same message oh then take that out. i was wondering why it would be including peer deps at all without that flag	20:48:27
Lily Foster	legacy-peer-deps does the opposite of what i suggested	20:48:44
Lily Foster	by overeagerly including them	20:48:55
pxc	I thought it was the other way around at any rate, removing it made no difference :(	20:53:33
pxc	* I thought it was the other way around. `--legacy-peer-deps` doesn't have any real documentation the `npm install` docs afaict, which is annoying at any rate, removing it made no difference :(	20:54:55
pxc	I'll try also adding `--no-optional`, I suppose	20:55:32
pxc	nope, `esbuild` is made about `--no-optional`. I guess if you use `esbuild`, `optionalDependencies` are actually required 🙃	20:58:07
pxc	* nope, `esbuild` is mad about `--no-optional`. I guess if you use `esbuild`, `optionalDependencies` are actually required 🙃	20:58:14
Lily Foster	In reply to @pxc:matrix.org nope, `esbuild` is made about `--no-optional`. I guess if you use `esbuild`, `optionalDependencies` are actually required 🙃 you can trivially get around that but also the problem here isn't optionalDependencies, but optional peerDependencies which are different	21:01:29
Lily Foster	* you can trivially get around that (search elsewhere in nixpkgs for prior art on esbuild insanity) but also the problem here isn't optionalDependencies, but optional peerDependencies which are different	21:02:25
pxc	well I have low confidence in the correctness but I did get a build that ran! since you pointed me at the `npmFlags` related to peer dependencies, I skimmed the NodeJS docs and decided to try `--omit peer` in place of `--legacy-peer-deps`, and the build succeeded the tool does run from that build and at least some commands work	21:15:29

Show newer messages

Back to Room ListRoom Version: 6