| 29 Aug 2025 |
|  Philip Taron (UTC-8) joined the room. | 00:36:22 |
| Philip Taron (UTC-8) | 383256 | 00:36:35 |
| Philip Taron (UTC-8) | * https://github.com/NixOS/nixpkgs/pull/383256
I'd love to commit this
can i get a reviewer | 00:37:16 |
|  magic_rb changed their profile picture. | 19:29:31 |
| 30 Aug 2025 |
 Cobalt | Hey, does anyone know the recommended way to run patchShebangs on the node_modules of workspace members?
The current implementation of buildNpmPackage only runs it once on the top-level node_modules leaving any workspace-level node_modules unpatched. This will lead to build errors if, e.g., the workspace members contain deps with shebangs, like vite.
postInstall doesn't appear to work/ be passed through so I only could get it to work as a buildPhase or configurePhase adjustment. Both of them however seem to be not really applicable to this step. It also feels like this should be accounted for by buildNpmPackage, especially given one can explicitly specify workspace members.
| 20:26:54 |
| Cobalt | (for context, I'm packaging jaeger-ui and they only include vite and some other deps as devDependencies of the workspace memeber packages/jaeger-ui. The build fails on calling vite in the build script of the workspace memeber as it has a /usr/bin/env node shebang and is unpatched as a consequence of landing in packages/jaeger-ui/node_modules/vite/bin/vite.js.) | 20:29:27 |
| Cobalt | * Hey, does anyone know the recommended way to run patchShebangs on the node_modules of workspace members?
The current implementation of buildNpmPackage only runs it once on the top-level node_modules leaving any workspace-level node_modules unpatched. This will lead to build errors if, e.g., the workspace members contain deps with shebangs, like vite.
postInstall doesn't appear to work/ be passed through so I only could get it to work as a buildPhase or configurePhase adjustment. Both of them however feel like the wrong Phase for this step. It also feels like this should be accounted for by buildNpmPackage, especially given one can explicitly specify workspace members.
| 20:30:54 |
| Cobalt | * Hey, does anyone know the recommended way to run patchShebangs on the node_modules of workspace members?
The current implementation of buildNpmPackage only runs it once on the top-level node_modules leaving any workspace-level node_modules unpatched. This will lead to build errors if, e.g., the workspace members contain deps with shebangs, like vite.
postInstall doesn't appear to work/ be passed through so I only could get it to work as a buildPhase or configurePhase adjustment. Both of them however feel like the wrong Phase for this step. It also seems like this should be accounted for by buildNpmPackage, especially given one can explicitly specify workspace members.
| 20:31:06 |
| Cobalt | * (for context, I'm packaging jaeger-ui and they only include vite and some other deps as devDependencies of the workspace member packages/jaeger-ui. The build fails on calling vite in the build script of the workspace member as it has a /usr/bin/env node shebang and is unpatched as a consequence of landing in packages/jaeger-ui/node_modules/vite/bin/vite.js.) | 20:31:25 |
| 2 Sep 2025 |
|  n3tcat joined the room. | 18:18:22 |
| n3tcat changed their display name from Stephen D to n3tcat. | 18:28:47 |
