| 21 Dec 2023 |
peter-lustig | with $env/dynamic/priavate everything just worked | 16:23:31 |
peter-lustig | but in sveltekit 2.0 it does not work anymore | 16:23:36 |
Lily Foster | well apparently prior to 2.0, there was no strong distinction between those types of vars apparently | 16:24:13 |
Lily Foster | * well apparently prior to 2.0, there was no strong distinction between those types of vars | 16:24:16 |
Lily Foster | i'm gonna look up more about how lucia-auth works real quick | 16:24:39 |
Lily Foster | oh apparently lucia-auth is now just under lucia for v2 | 16:24:58 |
Lily Foster | * oh apparently lucia-auth is now just under lucia for v2 | 16:25:05 |
Lily Foster | oh but other packages are the same. ignore me. i can't read | 16:25:15 |
Lily Foster | (reading https://lucia-auth.com/migrate/v2/ rn) | 16:25:19 |
Lily Foster | well that file looks correct according to https://lucia-auth.com/guidebook/github-oauth/sveltekit/#initialize-the-oauth-integration | 16:26:43 |
Lily Foster | where and how are you using githubAuth? | 16:26:48 |
peter-lustig | this has nothing to do with lucia auth, it is just the static stuff | 16:27:24 |
peter-lustig | for the env variables | 16:27:30 |
Lily Foster | hmm? | 16:28:43 |
peter-lustig | i do not get why they made this so confusing once again | 16:29:12 |
peter-lustig | instead of writing a proper migration guide | 16:29:31 |
Wanja Hentze | is it really fine to have the github oauth secret in the frontend? 😅 | 16:29:39 |
peter-lustig | for multiple deployment methods | 16:29:41 |
Lily Foster | In reply to @whentze:matrix.org is it really fine to have the github oauth secret in the frontend? 😅 that's what i'm hoping is not happening. but without more of the code, i can't tell | 16:29:52 |
peter-lustig | In reply to @whentze:matrix.org is it really fine to have the github oauth secret in the frontend? 😅 that never happens sveltekit errors out when you try to do that | 16:29:57 |
Wanja Hentze | oh cool | 16:30:06 |
peter-lustig | https://kit.svelte.dev/docs/server-only-modules#how-it-works | 16:31:07 |
Lily Foster | yeah but sure pre-rendering wouldn't matter for server-only modules, right? | 16:32:13 |
Lily Foster | * yeah but surely pre-rendering wouldn't matter for server-only modules, right? | 16:32:16 |
Lily Foster | unless it's getting propagated to the client somehow? idk i don't know much svelte | 16:32:33 |
peter-lustig | In reply to @lily:lily.flowers unless it's getting propagated to the client somehow? idk i don't know much svelte yeah it is | 16:33:12 |
peter-lustig | there is always a server route and a client route and you pass data from server to client | 16:33:25 |
peter-lustig | but yeah i guess you cannot help me here because you know not muc habout sveltekit | 16:34:43 |
peter-lustig | ill wait on an answer from someone on the discord | 16:34:52 |
Lily Foster | does sveltekit have a discord? spooky | 16:35:03 |