| 17 May 2023 |
 hexa | https://github.com/navidrome/navidrome/blob/master/ui/package.json | 21:21:14 |
 Lily Foster | Yeah I believe winter was hoping to fix the npmRoot PR later today. I think we're gonna end up just making the whole hook have a pushd/popd | 21:21:33 |
| hexa | yeah, that approach did work for me 🙂 | 21:21:48 |
| hexa | for update streams, what can I use to derive the hash for fetchNpmDeps? | 21:41:57 |
| hexa | is it prefetch-npm-deps? | 21:42:08 |
| Lily Foster | Yep, prefetch-npm-deps | 21:42:13 |
| hexa | I wonder whether I remembered that wrong, but didn | 21:43:07 |
| hexa | * I wonder whether I remembered that wrong, but didn't nix-update support updating those hashes? 🤔 | 21:43:18 |
| Lily Foster | Yes, nix-update does update npmDeps hashes | 21:43:29 |
| hexa | weird | 21:43:35 |
| Lily Foster | Did it not for you? | 21:43:44 |
| hexa | it went poof 😄 https://github.com/NixOS/nixpkgs/pull/229953#issuecomment-1552120774 | 21:43:57 |
| hexa | tried downgrading to 0.49.2 from 0.49.3 | 21:44:09 |
| Lily Foster | Wait why is the go-modules derivation running npmConfigHook 🤔 | 21:45:24 |
| hexa | 😄 | 21:45:38 |
| Lily Foster | Oh. The prePatch | 21:46:05 |
| hexa | npmRoot fix when 😄 | 21:46:21 |
| hexa | fixes the build, breaks the update workflow 😫 | 21:46:39 |
| Lily Foster | Well when npmRoot is working, it should fix the update script, right? | 21:47:03 |
| hexa | I would think so | 21:47:09 |
| Lily Foster | Okay, wasn't sure if I was misunderstanding | 21:47:17 |
| hexa | I have evcc which is basically doing the same, but without the need for npmRoot | 21:47:25 |
| hexa | would be great to sort this out before the release, because I did in fact tell people about buildNpmPackage, when I asked them to migrate off of node 14/16 🙂 | 21:48:51 |
| Lily Foster | I do fully intend to have these sorts of things fixed asap, since we're coming up so close on release and with the node 14/16 stuff | 21:49:45 |
| Lily Foster | So I'm thinking npm is ignoring the cache because it's may ending up in this code path, which throws an error without logging and that error gets silently caught (thanks npm, real cool): https://github.com/npm/pacote/blob/3307ad9c1600b6a60b2250c2239240ac41fc7b07/lib/fetcher.js#L317 | 21:53:06 |
| Lily Foster | * So I'm thinking npm is ignoring the cache because it's maybe ending up in this code path, which throws an error without logging and that error gets silently caught (thanks npm, real cool): https://github.com/npm/pacote/blob/3307ad9c1600b6a60b2250c2239240ac41fc7b07/lib/fetcher.js#L317 | 21:53:13 |
| Lily Foster | Time to add some debug logging and figure out what that cacache function is getting called with... hopefully it's not a bug, but npm having a ton of silently broken things because of their silently-bail-out-and-refetch logic all over the place is not news | 21:55:58 |
| Lily Foster | (like their hosted tarball url thing for gitlab is just straight up wrong and they have no intentions to fix it -- so when you do gitlab: deps they're unnecessarily way slower than any other hosted git provider because it tries the tarball, fails, and falls back to checkouts through complicated spaghetti code paths) | 21:57:00 |
| Lily Foster | (so it's "not a problem" because it handles it I guess) | 21:57:21 |
| hexa | yikes 😄 | 22:02:00 |
