| 17 Nov 2025 |
dish [Fox/It/She] | cuz then you just have constant merge conflicts | 04:01:39 |
dish [Fox/It/She] | In reply to @tomodachi94:matrix.org I'm going to check how big the generated lockfile ends up being. If it's pretty small it might commit it? fine to commit to nixpkgd if its small, but considering the number of deps it has listed im skeptical | 04:04:14 |
dish [Fox/It/She] | * <mx-reply><blockquote><a href="https://matrix.to/#/!NhAsaYbbgmzHtXTPQJ:funklause.de/$xBdgzYhGxTCUBRIj8B3BJNlm-M_VCjTGCKiXnqwea2k?via=pyrox.dev&via=matrix.org&via=nixos.dev">In reply to</a> <a href="https://matrix.to/#/@tomodachi94:matrix.org">@tomodachi94:matrix.org</a><br />I'm going to check how big the generated lockfile ends up being. If it's pretty small it might commit it?</blockquote></mx-reply>fine to commit to nixpkgs if its small, but considering the number of deps it has listed im skeptical | 04:04:25 |
dish [Fox/It/She] | * <mx-reply><blockquote><a href="https://matrix.to/#/!NhAsaYbbgmzHtXTPQJ:funklause.de/$xBdgzYhGxTCUBRIj8B3BJNlm-M_VCjTGCKiXnqwea2k?via=pyrox.dev&via=matrix.org&via=nixos.dev">In reply to</a> <a href="https://matrix.to/#/@tomodachi94:matrix.org">@tomodachi94:matrix.org</a><br />I'm going to check how big the generated lockfile ends up being. If it's pretty small it might commit it?</blockquote></mx-reply>fine to commit to nixpkgs if its small, but considering the number of deps it has listed in node-packages.nix im skeptical | 04:04:40 |
Tomodachi94 (they/them) | 308 kB... so pretty big | 04:06:10 |
dish [Fox/It/She] |
.>
| 04:06:23 |
dish [Fox/It/She] | * ugh | 04:06:32 |
dish [Fox/It/She] | yeah thats... a bit much for me to be okay with someone committing it | 04:07:04 |
Tomodachi94 (they/them) | Is it acceptable to have the lockfile fetched from a repository I maintain? | 04:07:04 |
dish [Fox/It/She] | i'd be fine with that | 04:07:51 |
Tomodachi94 (they/them) | "https://github.com/tomodachi94/package-lock.json-locker is my name, and basically being a CDN is my game" | 04:14:34 |
Tomodachi94 (they/them) | * | 04:15:06 |
dotlambda | In reply to @tomodachi94:matrix.org Is it acceptable to have the lockfile fetched from a repository I maintain? I don't think that's a good idea before there's consensus on doing so. And such a repo should probably be hosted under the NixOS org and come with a bot that regularly updates each lock file and then opens a Nixpkgs PR. Or at least updateScripts should be able to update the lock files, so we'd need some way of telling the bot to commit the lock file for a new version | 04:23:15 |
Tomodachi94 (they/them) | Hmm, I wonder if maybe he'd be okay with a lockfile getting attached to a GitHub Release automatically by a GitHub Action | 04:34:12 |
Tomodachi94 (they/them) | Asked very nicely for a lockfile to be included in https://github.com/sindresorhus/awesome-lint/issues/220 | 04:53:48 |
dish [Fox/It/She] | In reply to @robert:funklause.de I don't think that's a good idea before there's consensus on doing so. And such a repo should probably be hosted under the NixOS org and come with a bot that regularly updates each lock file and then opens a Nixpkgs PR. Or at least updateScripts should be able to update the lock files, so we'd need some way of telling the bot to commit the lock file for a new version yeah thats kinda rfc 191 that i need to flesh out more | 05:10:28 |
Tomodachi94 (they/them) | He said no, and then locked the issue | 18:08:07 |
Tomodachi94 (they/them) | (Pyrox: I'll try to review your PRs sometime today) | 18:08:32 |
dish [Fox/It/She] | In reply to @tomodachi94:matrix.org He said no, and then locked the issue called it sadly | 18:10:24 |
dish [Fox/It/She] | 😠| 18:10:27 |
Tomodachi94 (they/them) | Another option if we can get consensus is we could move nodePackages to a flake under nix-community | 18:11:31 |
dish [Fox/It/She] | In reply to @tomodachi94:matrix.org (Pyrox: I'll try to review your PRs sometime today) all good btw, take ur time | 18:14:11 |
dish [Fox/It/She] | In reply to @tomodachi94:matrix.org Another option if we can get consensus is we could move nodePackages to a flake under nix-community i mean its still a terrible solution to the problem so I'd rather not have it around, and idk who'd want to maintain it anyways | 18:14:48 |
dish [Fox/It/She] | i'm certainly not going to | 18:15:45 |
Tomodachi94 (they/them) | I'm inclined to suggest that maybe we should just drop all of Sindre Sorhus' stuff from nodePackages since he's anti-lockfile and there's no other good solution at the moment. Other than that, it might be time to start filing issues en masse to upstreams
We should definitely make a statement that we can copy/paste and gently edit for each project
| 19:34:18 |
Tomodachi94 (they/them) | * I'm inclined to suggest that maybe we should just drop all of Sindre Sorhus' stuff from nodePackages since he's anti-lockfile and there's no other good solution at the moment. Other than that, it might be time to start filing issues en masse to upstreams
We should definitely make a statement that we can copy/paste and gently edit for each project that hasn't already expressed an anti-lockfile stance
| 19:36:06 |
dish [Fox/It/She] | In reply to @tomodachi94:matrix.org
I'm inclined to suggest that maybe we should just drop all of Sindre Sorhus' stuff from nodePackages since he's anti-lockfile and there's no other good solution at the moment. Other than that, it might be time to start filing issues en masse to upstreams
We should definitely make a statement that we can copy/paste and gently edit for each project that hasn't already expressed an anti-lockfile stance
i've considered doing that tbh because of his lockfile stance
just thought it was a bit too petty for nixpkgs >.> though if we do it, fine with me | 20:25:10 |
dotlambda | I don't think dropping is a bad idea. nodePackages has been deprecated forever and if packages haven't been moved out of it yet we can conclude there's no interest in keeping them around | 21:34:59 |
dotlambda | Has to wait until after branch-off though | 21:35:22 |
dish [Fox/It/She] | i mean thats not necessarily true | 21:48:57 |