!NhAsaYbbgmzHtXTPQJ:funklause.de

Nix NodeJS

186 Members
55 Servers

Load older messages


SenderMessageTime
17 Nov 2025
@pyrox:pyrox.devdish [Fox/It/She]and we dont even have bun yet(though that is also being worked on?)03:59:21
@tomodachi94:matrix.orgTomodachi94 (they/them)I'm going to check how big the generated lockfile ends up being. If it's pretty small it might commit it?03:59:26
@pyrox:pyrox.devdish [Fox/It/She]* also frankly i want to unify the JS dependency fetchers (fetchNpmDeps, fetchYarnDeps, pnpm.fetchDeps, and the still in PR fetchDenoDeps) cuz theres too much divergence between them04:00:00
@tomodachi94:matrix.orgTomodachi94 (they/them)As for lockfile maintenance for applications: my opinion is that lockfiles don't need to be updated on every single change, but definitely do it right before a release... but unfortunately this is not Sorhus' opinion04:00:49
@pyrox:pyrox.devdish [Fox/It/She]oh yeah if ur updating ur lockfile constantly thats an issue04:01:16
@pyrox:pyrox.devdish [Fox/It/She]cuz then you just have constant merge conflicts04:01:39
@pyrox:pyrox.devdish [Fox/It/She]
In reply to @tomodachi94:matrix.org
I'm going to check how big the generated lockfile ends up being. If it's pretty small it might commit it?
fine to commit to nixpkgd if its small, but considering the number of deps it has listed im skeptical
04:04:14
@pyrox:pyrox.devdish [Fox/It/She]* <mx-reply><blockquote><a href="https://matrix.to/#/!NhAsaYbbgmzHtXTPQJ:funklause.de/$xBdgzYhGxTCUBRIj8B3BJNlm-M_VCjTGCKiXnqwea2k?via=pyrox.dev&via=matrix.org&via=nixos.dev">In reply to</a> <a href="https://matrix.to/#/@tomodachi94:matrix.org">@tomodachi94:matrix.org</a><br />I'm going to check how big the generated lockfile ends up being. If it's pretty small it might commit it?</blockquote></mx-reply>fine to commit to nixpkgs if its small, but considering the number of deps it has listed im skeptical04:04:25
@pyrox:pyrox.devdish [Fox/It/She]* <mx-reply><blockquote><a href="https://matrix.to/#/!NhAsaYbbgmzHtXTPQJ:funklause.de/$xBdgzYhGxTCUBRIj8B3BJNlm-M_VCjTGCKiXnqwea2k?via=pyrox.dev&via=matrix.org&via=nixos.dev">In reply to</a> <a href="https://matrix.to/#/@tomodachi94:matrix.org">@tomodachi94:matrix.org</a><br />I'm going to check how big the generated lockfile ends up being. If it's pretty small it might commit it?</blockquote></mx-reply>fine to commit to nixpkgs if its small, but considering the number of deps it has listed in node-packages.nix im skeptical04:04:40
@tomodachi94:matrix.orgTomodachi94 (they/them)308 kB... so pretty big04:06:10
@pyrox:pyrox.devdish [Fox/It/She]

.>

04:06:23
@pyrox:pyrox.devdish [Fox/It/She]* ugh04:06:32
@pyrox:pyrox.devdish [Fox/It/She]yeah thats... a bit much for me to be okay with someone committing it04:07:04
@tomodachi94:matrix.orgTomodachi94 (they/them)Is it acceptable to have the lockfile fetched from a repository I maintain?04:07:04
@pyrox:pyrox.devdish [Fox/It/She]i'd be fine with that04:07:51
@tomodachi94:matrix.orgTomodachi94 (they/them)"https://github.com/tomodachi94/package-lock.json-locker is my name, and basically being a CDN is my game"04:14:34
@tomodachi94:matrix.orgTomodachi94 (they/them) * 04:15:06
@robert:funklause.dedotlambda
In reply to @tomodachi94:matrix.org
Is it acceptable to have the lockfile fetched from a repository I maintain?
I don't think that's a good idea before there's consensus on doing so.
And such a repo should probably be hosted under the NixOS org and come with a bot that regularly updates each lock file and then opens a Nixpkgs PR.
Or at least updateScripts should be able to update the lock files, so we'd need some way of telling the bot to commit the lock file for a new version
04:23:15
@tomodachi94:matrix.orgTomodachi94 (they/them)Hmm, I wonder if maybe he'd be okay with a lockfile getting attached to a GitHub Release automatically by a GitHub Action04:34:12
@tomodachi94:matrix.orgTomodachi94 (they/them)Asked very nicely for a lockfile to be included in https://github.com/sindresorhus/awesome-lint/issues/22004:53:48
@pyrox:pyrox.devdish [Fox/It/She]
In reply to @robert:funklause.de
I don't think that's a good idea before there's consensus on doing so.
And such a repo should probably be hosted under the NixOS org and come with a bot that regularly updates each lock file and then opens a Nixpkgs PR.
Or at least updateScripts should be able to update the lock files, so we'd need some way of telling the bot to commit the lock file for a new version
yeah thats kinda rfc 191 that i need to flesh out more
05:10:28
@tomodachi94:matrix.orgTomodachi94 (they/them)He said no, and then locked the issue18:08:07
@tomodachi94:matrix.orgTomodachi94 (they/them)(Pyrox: I'll try to review your PRs sometime today)18:08:32
@pyrox:pyrox.devdish [Fox/It/She]
In reply to @tomodachi94:matrix.org
He said no, and then locked the issue
called it sadly
18:10:24
@pyrox:pyrox.devdish [Fox/It/She]😭18:10:27
@tomodachi94:matrix.orgTomodachi94 (they/them)Another option if we can get consensus is we could move nodePackages to a flake under nix-community18:11:31
@pyrox:pyrox.devdish [Fox/It/She]
In reply to @tomodachi94:matrix.org
(Pyrox: I'll try to review your PRs sometime today)
all good btw, take ur time
18:14:11
@pyrox:pyrox.devdish [Fox/It/She]
In reply to @tomodachi94:matrix.org
Another option if we can get consensus is we could move nodePackages to a flake under nix-community
i mean its still a terrible solution to the problem so I'd rather not have it around, and idk who'd want to maintain it anyways
18:14:48
@pyrox:pyrox.devdish [Fox/It/She]i'm certainly not going to18:15:45
@tomodachi94:matrix.orgTomodachi94 (they/them)

I'm inclined to suggest that maybe we should just drop all of Sindre Sorhus' stuff from nodePackages since he's anti-lockfile and there's no other good solution at the moment. Other than that, it might be time to start filing issues en masse to upstreams

We should definitely make a statement that we can copy/paste and gently edit for each project

19:34:18

Show newer messages


Back to Room ListRoom Version: 6