Nix NodeJS | 196 Members | |
| 57 Servers |
| Sender | Message | Time |
|---|---|---|
| 30 Apr 2024 | ||
In reply to @matejam:matrix.org(if you want, you can set npmBuildScript = "prod" and include npmBuildHook as well) | 20:46:36 | |
In reply to @matejam:matrix.org* (if you want, you can set npmBuildScript = "prod" and include npmBuildHook as well and remove the postBuild) | 20:46:41 | |
| Iirc, the nodejs 22 LTS has some problems with node gyp. You might want to stick with 18 for a few more weeks until testing has been done | 20:46:49 | |
In reply to @c0ba1t:matrix.orgwell if they're using npmHooks and nodejs, it'll be 20 for a bit | 20:47:13 | |
i don't think nixpkgs has set nodejs = nodejs_22 yet (just node_20) | 20:47:27 | |
In reply to @c0ba1t:matrix.org(also what problems? that's concerning if their build tool didn't work on release....) | 20:47:44 | |
| ( | 20:47:54 | |
Hm, for some reason if I do that it doesn't generate files that | 20:56:46 | |
| Iirc, it is on 22 on unstable. I don't remember the specifics but an unstable bum recently made our builds fail until we returned to 18. Iirc, it was similar to https://github.com/nodejs/node-gyp/issues/3029 | 20:59:57 | |
In reply to @matejam:matrix.orgshare derivation? (e.g. on a pastebin?) that seems weird | 21:00:53 | |
| oh you know what | 21:01:00 | |
In reply to @c0ba1t:matrix.orgbut it was 20 before 22, did 20 not work either? | 21:01:19 | |
In reply to @lily:lily.flowersi wonder if it's because the composer stuff changes build to that dir first | 21:02:06 | |
| if it's working now, leave it as-is then :) | 21:02:13 | |
Yeah, maybe even the other way around. In the logs I see first the npm runs and then composer>
sure 😄
If you are interested, I can make a new branch with the change. It's my open source project anyway | 21:04:59 | |
*
Yeah, maybe even the other way around. In the logs I see first the npm runs and then composer.
sure 😄
If you are interested, I can make a new branch with the change. It's my open source project anyway | 21:05:17 | |
In reply to @matejam:matrix.orgnah, i'm pretty sure it's because composer changes dir and you want npm to run after that. so you're doing it right enough and this looks pretty awesome actually :) | 21:05:34 | |
| it feels neat that you are able to mix the npm hooks into another builder without too much fuss and have a multi-language-package-manager app build in a derivation like that | 21:06:10 | |
In reply to @c0ba1t:matrix.orgoooof. well marsam left and i'm recovering from surgery, so someone else will probably have to bump the nodejs derivation | 21:09:32 | |
In reply to @lily:lily.flowers(no one else is on nodejs team rn except winter who also hasn't had time for things....) | 21:10:15 | |
Yeah, Composer also has it's own version of fetchNpmDeps (mkComposerRepository) but I couldn't really make it work. I don't know how it would handle 3 or more language app builds 😂 I'm glad that it works for 2 | 21:10:14 | |
In reply to @lily:lily.flowersIt looks like the fix for the upstream issue was merged today. Though, by the comments on the MR, it will likely take a bit until a patch release will be published. So there's no need to hurry here. | 21:27:35 | |
| I'll try to make a PR when 20.0.1 gets released. | 21:28:23 | |
In reply to @c0ba1t:matrix.org(well hurry or not, i'm just making clear i don't think anyone from nodejs team will be touching it any time soon) | 21:46:15 | |
In reply to @c0ba1t:matrix.orgi assume you mean 22.0.1, but thank you! | 21:46:36 | |
| 1 May 2024 | ||
| 15:06:24 | ||
| 2 May 2024 | ||
| 03:33:06 | ||
| 04:11:49 | ||
| 21:02:51 | ||
| 4 May 2024 | ||
| 01:59:39 | ||