Nix NodeJS | 198 Members | |
| 57 Servers |
| Sender | Message | Time |
|---|---|---|
| 30 Jan 2024 | ||
| https://github.com/NixOS/nixpkgs/pull/251687 hmm | 00:53:34 | |
| I think I am now uniquely qualified to review that existing PR | 00:53:46 | |
In reply to @hexa:lossy.networki can't tell how or why this would be the case, by some quick looking through the code on mobile 👀 | 00:55:41 | |
| ugh, mobile 😄 | 00:55:54 | |
| don' | 00:55:55 | |
| * don't do that | 00:55:57 | |
In reply to @hexa:lossy.network(it is, uh, hurting to use gh's search for this on mobile, yeah...) | 00:56:41 | |
| https://github.com/NixOS/nixpkgs/pull/251687/files#diff-0484e02777f32406a41a22e3f48f96f437ec183b1d3d3f9533d67370e6fb0620R49-R63 | 00:57:30 | |
| this hurts as well 😄 | 00:57:33 | |
| that whole installPhase is wild | 00:58:22 | |
| I can't get npm to write a non broken lockfile for me, any ideas? I tried with npm 9.8.1, 10.2.4 and 1.4.0 on different systems and all don't add integrity and resolved fields for a few dependencies I tried running npm-lockfile-fix but this also seems to break the lockfile | 09:32:03 | |
| * I can't get npm to write a non broken lockfile for me, any ideas? I tried with npm 9.8.1, 10.2.4 and 10.4.0 on different systems and all don't add integrity and resolved fields for a few dependencies I tried running npm-lockfile-fix but this also seems to break the lockfile | 09:32:12 | |
| I also deleted node_modules, package-lock.json and the npm cache before running npm install | 09:33:06 | |
In reply to @marie:marie.cologneare these peer deps by any chance? | 10:10:23 | |
| no, but the project is a workspace and the dependencies with issues seem to be used in different versions across workspace packages | 10:11:09 | |
| oh, I've seen that with workspaces too, but sadly don't remember the fix :/ | 10:18:57 | |
| i get a different lockfile with a different runtime error when generating the lockfile on a non NixOS machine, with the same nodejs package from nixpkgs 😵💫 | 10:49:47 | |
| hey, npm can barely behave reproducibly when given an existing lockfile, and you're expecting lockfile generation to be reproducible? :D | 10:59:57 | |
| fair | 11:10:43 | |
| but getting very different lockfiles from the exact same version doesn't look good | 11:17:38 | |
In reply to @marie:marie.colognecan you share package.json and the lockfile? | 11:56:55 | |
In reply to @lily:lily.flowersupstream lockfile: https://github.com/appium/appium/blob/master/package-lock.json lockfile i got on non nixos system: https://github.com/appium/appium/blob/6365189b729548fe0e1591000634291c7e7a126c/package-lock.json lockfile from nixos system: https://github.com/appium/appium/blob/591bc0f96eeebb72252d7eb996ef0068993c23e1/package-lock.json | 12:41:17 | |
| (maybe we should just dump npm and only use pnpm. pretty sure it's lockfiles are significantly less busted out in the wild) | 12:42:35 | |
| * (maybe we should just dump npm and only use pnpm. pretty sure its lockfiles are significantly less busted out in the wild) | 12:42:45 | |
| i got another clue from a colleague, i forgot to delete the subpackage node_modules folders. that might explain the package lock differences | 12:47:34 | |
| but it still throws an error when trying to run it, not sure if that is buildNpmPackage's fault | 12:48:36 | |
| i'll try to debug that another time | 12:49:32 | |
In reply to @marie:marie.cologneshare log? | 13:04:04 | |
| oh sorry, forgot to send
| 13:08:34 | |
| 31 Jan 2024 | ||
| 03:35:49 | ||