In reply to @peter-lustig:matrix.org

Lily Foster: could you help me with packaging my nodejs app? These are the requirements:

*First,

You will need the output directory, the project's package.json, and the production dependencies in node_modules to run the application. Production dependencies can be generated by copying the package.json and package-lock.json and then running npm ci --omit dev (you can skip this step if your app doesn't have any dependencies). You can then start your app with this command:

node build
Development dependencies will be bundled into your app using Rollup. To control whether a given package is bundled or externalised, place it in devDependencies or dependencies respectively in your package.json.*

This is what I have:

buildInputs = with pkgs; [
        nodejs_20
      ];
      src = ./.;
      npmDepsHash = "sha256-mTpjBKTIJkYVj2jrH5lF/n3Axceak4L60ZDQECQhGew=";
      npmBuild = "npm run build";
      npmInstallFlags = [ "--omit dev" ];
      installPhase = ''
        mkdir $out
        cp -r build/* $out
        cp package.json $out
        cp package-lock.json $out
      '';

In reply to @lily:lily.flowers
are you able to share more info on the npm package itself?

In reply to @lily:lily.flowers
you might just need to add build as a dir for npm package in your package.json

this might just be fine:

buildNpmPackage {
  src = ./.;
  npmDepsHash = "sha256-mTpjBKTIJkYVj2jrH5lF/n3Axceak4L60ZDQECQhGew=";
  installPhase = ''
    cp -r build $out
  '';
  nodejs = nodejs_20;
}

In reply to @lily:lily.flowers

this might just be fine:

buildNpmPackage {
  src = ./.;
  npmDepsHash = "sha256-mTpjBKTIJkYVj2jrH5lF/n3Axceak4L60ZDQECQhGew=";
  installPhase = ''
    cp -r build $out
  '';
  nodejs = nodejs_20;
}

In reply to @c0ba1t:matrix.org
Isn't this one missing the {pre,post}install hooks?

In reply to @c0ba1t:matrix.org
It does on 23.05: https://search.nixos.org/packages?channel=23.05&from=0&size=50&sort=relevance&type=packages&query=nodejs

In reply to @lily:lily.flowers
actually maybe move build somewhere more useful

maybe something like this if you want a bin you can just execute

buildNpmPackage {
  src = ./.;
  npmDepsHash = "sha256-mTpjBKTIJkYVj2jrH5lF/n3Axceak4L60ZDQECQhGew=";
  nodejs = pkgs.nodejs_20;
  nativeBuildInputs = [ pkgs.makeWrapper ];
  installPhase = ''
    mkdir -p $out/lib/node_modules
    cp -r build $out/lib/node_modules/sveltepackage

    makeWrapper ${pkgs.nodejs-slim_20}/bin/node $out/bin/sveltepackage \
      --add-flags $out/lib/node_modules/sveltepackage
  '';
}

In reply to @lily:lily.flowers
(note you need to be on like nixpkgs master to get the nodejs arg on buildNpmPackage)

In reply to @peter-lustig:matrix.org
ah okay, but isnt buildInputs = [ nodejs_20 ] dong the same