| 31 Oct 2023 |
Lily Foster | i wrote the code for that. and tested it | 19:52:15 |
Lily Foster | and it got merged ages ago | 19:52:20 |
Wanja Hentze | huh | 19:52:20 |
Lily Foster | and it does fetch parallel and always has | 19:52:37 |
Wanja Hentze | we just put it in a mid-sized react project | 19:52:42 |
Lily Foster | (i actually recently made it respect NIX_BUILD_CORES or whatever the env var is not long ago) | 19:52:54 |
Wanja Hentze | yes it does fetch in parallel, that is part of the problem | 19:52:55 |
Lily Foster | What nixpkgs branch are you working off of? | 19:53:08 |
Wanja Hentze | uhh unstable but this was a couple weeks ago | 19:53:29 |
Wanja Hentze | I could try again | 19:53:36 |
Lily Foster | rev? | 19:53:58 |
Wanja Hentze | dunno, I'm on the phone | 19:54:07 |
Lily Foster | these fixes were all merged more than a few weeks ago i thought | 19:54:08 |
Wanja Hentze | sry | 19:54:13 |
Lily Foster | no it's okay! | 19:54:16 |
Lily Foster | i'm just confused 😅 | 19:54:20 |
Wanja Hentze | very possible that they have | 19:54:25 |
Lily Foster | Well I think the retries failing for response bodies issue was more recent | 19:54:46 |
Wanja Hentze | another weird failure mode we saw: the fetcher seemed to ignore HTTP 4XX from the remote and would just try to decode the body (which was text/html saying "permission denied" or sth) as a tarball | 19:55:22 |
Wanja Hentze | maybe that's fixed too | 19:55:36 |
Lily Foster | quite possibly? i do appreciate you bringing these issues up though | 19:55:50 |
Lily Foster | do you think when you run into them you could open nixpkgs issues and ping me and/or the node team on thme? | 19:56:01 |
Lily Foster | * do you think when you run into them you could open nixpkgs issues and ping me and/or the node team on them? | 19:56:02 |
Lily Foster | we are very interesting in fixing stuff like that | 19:56:09 |
Lily Foster | * we are very interested in fixing stuff like that | 19:56:13 |
Wanja Hentze | In reply to @lily:lily.flowers do you think when you run into them you could open nixpkgs issues and ping me and/or the node team on them? yes | 19:56:24 |
Wanja Hentze | for now I'm still trying to make dream2nix work though | 19:56:43 |
Wanja Hentze | because I really really want to not prefetch | 19:56:51 |
Lily Foster | Would you be interested in testing importNpmLock functionality when we have that ready? It'll function similarly to the importCargoLock tooling from rust and won't require prefetched FODs | 19:57:37 |
Wanja Hentze | oh nice | 20:12:10 |