| 23 Aug 2023 |
 Lily Foster | In reply to @robert:funklause.de
Please review and merge if you have some spare time. I don't wanna accrue merge conflicts. I can do that sometime in the next couple hours. The nodePackages hell-set does tend to accumulate merge conflicts quickly... | 11:25:24 |
| 24 Aug 2023 |
| Lily Foster | In reply to @robert:funklause.de
Please review and merge if you have some spare time. I don't wanna accrue merge conflicts. Merged. And naturally it immediately created a merge conflict with https://github.com/NixOS/nixpkgs/pull/250250, but I already left another review comment on that one anyway | 00:53:27 |
| Lily Foster | In reply to @gdesforges:matrix.org
Lily Foster: I've closed previous PR and pushed a new PR https://github.com/NixOS/nixpkgs/pull/248107 Apologies for taking a minute there to get back to this, but I left one super minor nit (which tbh doesn't need to be a blocker for merge, so feel free to ask it to just be merged if you'd rather not fix it) | 00:54:13 |
| Lily Foster | In reply to @lily:lily.flowers
Merged. And naturally it immediately created a merge conflict with https://github.com/NixOS/nixpkgs/pull/250250, but I already left another review comment on that one anyway (thank you for your recent node work btw dotlambda, you've been fabulous ❤️) | 00:55:22 |
| Lily Foster | (I finally got a chance to look at the manpages PR and I saw it was accidentally merged a little early (probably because I didn't get to it in time), but it looks fine to me assuming it passed testing) | 00:57:42 |
 @gdesforges:matrix.org | In reply to @lily:lily.flowers
Apologies for taking a minute there to get back to this, but I left one super minor nit (which tbh doesn't need to be a blocker for merge, so feel free to ask it to just be merged if you'd rather not fix it) thanks a lot! I've applied your change 👍️ | 07:34:01 |
| @gdesforges:matrix.org | who should I ask for merge? | 07:34:08 |
| @gdesforges:matrix.org | * who should I ask for a merge? | 07:34:17 |
 raitobezarius | me | 09:35:45 |
| @gdesforges:matrix.org | thanks raitobezarius | 15:07:25 |
| @gdesforges:matrix.org | and ofc thx Lily Foster | 15:07:33 |
| @gdesforges:matrix.org | I really use this tool a lot, having it installed via home-manager will make my life easier | 15:07:58 |
| Lily Foster | Yep happy we could get it working :)
(I'm just sorry I've been so busy and took what I realized was a few weeks yesterday to get to it...) | 15:08:43 |
| raitobezarius | thank you Lily Foster for all your efforts | 15:09:37 |
 dotlambda | Lily Foster: Could you add details to https://github.com/LibreScore/dl-librescore/pull/32#issuecomment-1692558038 ? The Nixpkgs manual has none | 23:51:01 |
| Lily Foster | In reply to @robert:funklause.de
Lily Foster: Could you add details to https://github.com/LibreScore/dl-librescore/pull/32#issuecomment-1692558038 ? The Nixpkgs manual has none Yeah I'll try to chime in tomorrow, if that's okay. Not sure I have the energy tonight | 23:55:38 |
| dotlambda | No worries | 23:56:36 |
| dotlambda | Though if you have a link that would be handy | 23:56:57 |
| Lily Foster | There's not stuff in the manual exactly (because I'm deliquent...), but I can explain what's up with it and what might help us out | 23:58:03 |
| Lily Foster | In the thread | 23:58:12 |
| 27 Aug 2023 |
| dotlambda | Should we add --build-from-source to npmInstallFlags by default?
See https://github.com/prebuild/node-gyp-build/blob/master/README.md#usage
Though because of https://github.com/prebuild/node-gyp-build/blob/master/bin.js#L11 the prebuild is used anyway if building from source doesn't work. | 02:26:56 |
| dotlambda | Maybe we should make node-gyp-build an alias for node-gyp build unless some flag is set. | 02:28:12 |
| Lily Foster | In reply to @robert:funklause.de
Maybe we should make node-gyp-build an alias for node-gyp build unless some flag is set. Yeah tbh I was considering this option more | 13:20:36 |
| Lily Foster | In reply to @robert:funklause.de
Lily Foster: Could you add details to https://github.com/LibreScore/dl-librescore/pull/32#issuecomment-1692558038 ? The Nixpkgs manual has none Heck. I forgot about this. I'll try to do that today | 13:21:20 |
| 29 Aug 2023 |
|  aktaboot left the room. | 05:18:21 |
| 30 Aug 2023 |
|  xigen38112 joined the room. | 09:10:55 |
| 31 Aug 2023 |
|  Adrian Hesketh joined the room. | 12:09:56 |
| 4 Sep 2023 |
|  @nord:one.ems.host left the room. | 04:01:44 |
| 8 Sep 2023 |
|  @ulli:hrnz.li left the room. | 20:42:52 |
| 9 Sep 2023 |
| Lily Foster | In reply to @janne.hess:helsinki-systems.de
This causes (buildNpmPackage.override { nodejs = nodejs_14; }) to fail horribly Hey I think https://github.com/NixOS/nixpkgs/pull/253181 fixed your problem. Do you want to test it? | 15:59:44 |
