| 8 Aug 2023 |
@gdesforges:matrix.org | In reply to @lily:lily.flowers Unless I'm misreading, the yarn.lock you committed is different from the upstream yarn.lock at 3.1.0...? Well that could be a thing | 22:31:50 |
Lily Foster | Hmmm still doesn't work after updating to 3.2.0 | 22:32:16 |
Lily Foster | So I'm gonna pull down a fresh lockfile for that version so I have a better comparison (I did the diff and noticed a bunch of them were different only in version number) | 22:32:39 |
Lily Foster | (which made no sense for locked deps 🤔) | 22:32:52 |
Lily Foster | Heck I'm gonna have to regenerate yarn.nix aren't I. I don't even know how to do that, I like touching yarn2nix as little as possible | 22:33:50 |
Lily Foster | Okay you're gonna love this. Now it doesn't work with vendored yarn.lock either with 3.2.0 🫠 | 22:36:42 |
@gdesforges:matrix.org | Just call `yarn2nix` in the folder | 22:36:43 |
@gdesforges:matrix.org | And write stdout to yarn.nix | 22:36:52 |
Lily Foster | Yep, I figured it out, thank you! | 22:36:59 |
@gdesforges:matrix.org | Trying my best to support you 😄 | 22:37:17 |
Lily Foster | So the only diff is this:
Binary files /nix/store/dbzacnpaxdzfgj7nymm68bp8hfsdj651-offline/5dd91d76ba088119836f60f514dc0a0b8b30e78d and /nix/store/zlshz8zl6sg705kbj0d8d3ha7qyhlzs6-offline/5dd91d76ba088119836f60f514dc0a0b8b30e78d differ
| 22:37:30 |
Lily Foster | Which shouldn't matter | 22:37:33 |
@gdesforges:matrix.org | Go go go Lily! 👐 | 22:37:36 |
Lily Foster | But now vendored and non-vendored get the exact same error | 22:37:42 |
Lily Foster | So something's hecked somewhere | 22:37:45 |
Lily Foster | And idk where you got your lockfile from | 22:37:49 |
Lily Foster | The one that did work | 22:37:53 |
@gdesforges:matrix.org | From marp-cli GitHub repo tag 3.1.0 | 22:38:23 |
Lily Foster | Did they retag or something? It differed from what I pulled from the tag | 22:38:43 |
Lily Foster | In reply to @gdesforges:matrix.org From marp-cli GitHub repo tag 3.1.0 When I run this from your branch, they do not match:diff "$(nix eval --raw .#marp-cli.src)/yarn.lock" pkgs/tools/typesetting/marp/yarn.lock | 22:39:53 |
@gdesforges:matrix.org | https://github.com/marp-team/marp-cli/blob/a6a3fd21f605e4dcc723aacd9649b9e4c92de021/yarn.lock | 22:40:26 |
@gdesforges:matrix.org | Well I'll be damned | 22:40:42 |
@gdesforges:matrix.org | IDK | 22:40:44 |
Lily Foster | So that you can poke at the same thing I am if you want, I just pushed to https://github.com/lilyinstarlight/nixpkgs/tree/tmp/marp | 22:41:45 |
Lily Foster | For 3.2.0 | 22:41:48 |
Lily Foster | With the upstream lockfile I directly curl'd | 22:41:55 |
Lily Foster | github:lilyinstarlight/nixpkgs/tmp/marp#marp-cli if you wanted to build it from flake uri | 22:43:32 |
Lily Foster | Hmmm I think this might be a yarn2nix bug | 22:44:13 |
Lily Foster | I'm gonna try it using fetchYarnDeps and mkDerivation instead of mkYarnPackage and see what it does | 22:44:29 |
Lily Foster | Yeah this is 100% a yarn2nix bug. I just built marp-cli without it just fine | 22:53:42 |