| 31 Jul 2023 |
 dotlambda | Now I get Error: Cannot find module 'jsonc-parser' and would need /package-lock.json though I can patch out the dependency on jsonc-parser.
Doing so leads to lots of missing modules required from packages/pyright-internal :( | 21:21:18 |
 gdamjan | In reply to @hexa:lossy.network
ERROR:CLI Error: Could not find package.json up from /nix/store/qvpjwskw6j9n4g8749snwj5b6nk9xsb1-matrix-appservice-irc-1.0.1/bin/matrix-appservice-irc
why didn't I see this though?! | 21:22:12 |
 hexa | i havent got the feintest idea | 21:23:13 |
 Lily Foster | In reply to @robert:funklause.de
Now I get Error: Cannot find module 'jsonc-parser' and would need /package-lock.json though I can patch out the dependency on jsonc-parser.
Doing so leads to lots of missing modules required from packages/pyright-internal :( Yeah I figured if they were using lerna you'd run into issues with intra-repo dependencies. Which lerna does custom handling for :/ | 21:24:32 |
| Lily Foster | And splits them across package-lock.json files because they hate nice things | 21:25:19 |
| dotlambda | I pushed all my changes, feel free to play around with it. I'll stop investing time in pyright for now | 21:26:06 |
| Lily Foster | In reply to @robert:funklause.de
I pushed all my changes, feel free to play around with it. I'll stop investing time in pyright for now I may. The problem is lerna is gonna need work on our side to be actually usable instead of being able to hack around it | 21:27:29 |
| Lily Foster | And I was going to say you could maybe get away with packaging the tarball for pyright in the npm registry, but it looks like that doesn't contain a lockfile | 21:27:56 |
| dotlambda | In reply to @lily:lily.flowers
I may. The problem is lerna is gonna need work on our side to be actually usable instead of being able to hack around it Then I guess there are more important things to work on | 21:28:01 |
| Lily Foster | * And I was going to say you could maybe get away with packaging the tarball for pyright from the npm registry, but it looks like that doesn't contain a lockfile | 21:28:03 |
| Lily Foster | In reply to @robert:funklause.de
Then I guess there are more important things to work on If you want to work on that, feel free to, but it'll be a while before we get there. We really should come up with at least some workarounds though for packaging lerna apps since they keep popping up (even though npm has native monorepo support with workspaces now which we do support since it didn't actually take that much extra effort) | 21:29:30 |
| Lily Foster | (I'm not even sure what's the best way to handle lerna tbh. I've never used it and it's been rather annoying when toying with trying to build lerna repos with npm) | 21:30:58 |
| Lily Foster | * (I'm not even sure what's the best way to handle lerna tbh. I've never used it and it's been rather annoying when toying with trying to build lerna repos with npm alone) | 21:31:07 |
| Lily Foster | (if you really want though, you could use the npm registry tarball as src and then copy in a vendored lockfile in postPatch. But I really don't want to vendor any more lockfiles than we have to in nixpkgs.....) | 21:31:47 |
| Lily Foster | (especially with how big npm ones get) | 21:32:04 |
| gdamjan | In reply to @gdamjan:spodeli.org
why didn't I see this though?! I did run the tests too 😱 | 21:54:04 |
| 1 Aug 2023 |
| gdamjan | how exactly did you get this? just running the CLI doesn't error out for me | 07:59:03 |
| hexa | so did I | 10:54:28 |
| hexa | ofborg also ran them and they were green before merge | 10:54:40 |
| gdamjan | what's the game plan now? add the package.json file back, and perhaps add strictDeps=true? | 11:11:09 |
| hexa | yes | 11:38:38 |
| gdamjan | https://github.com/NixOS/nixpkgs/pull/246554 | 11:58:57 |
| dotlambda | Do we want to support npm-shrinkwrap.json in buildNpmPackage? | 16:01:49 |
| Lily Foster | In reply to @robert:funklause.de
Do we want to support npm-shrinkwrap.json in buildNpmPackage? If someone wants to write it. Right now it's not on our radar though | 16:03:53 |
| dotlambda | In reply to @lily:lily.flowers
If someone wants to write it. Right now it's not on our radar though Doesn't it have the exact same syntax? So it would just require checking which of the two files is present | 16:04:25 |
| Lily Foster | Are you interested in adding more of this stuff? Do you want to join the nixpkgs node.js team? | 16:04:41 |
| Lily Foster | In reply to @robert:funklause.de
Doesn't it have the exact same syntax? So it would just require checking which of the two files is present Hmm yeah I think it might be. I'll have to double check | 16:04:57 |
| dotlambda | In reply to @lily:lily.flowers
Are you interested in adding more of this stuff? Do you want to join the nixpkgs node.js team? Not really, I don't actually know Node.js :D | 16:05:06 |
| Lily Foster | In reply to @robert:funklause.de
Not really, I don't actually know Node.js :D Hey, neither did I when I joined 🙃 | 16:06:28 |
| Lily Foster | (I'm only partly joking in that too...) | 16:06:47 |
